GitLab

Previously, the code was only making sure whitespace was removed, but other parts of Mahara depend on this field having only alphabetical characters.

Now the code makes sure only alphabetical characters are in the string, and will cycle through the letters a - z attempting to generate a new institution name if the one generated is already taken.

If someone needs more than 26 peers all with the same name... well tough :)

As pointed out in the bug, there's more reasons to not do it than there are to do it.
(cherry picked from commit b65afd98)

Prevent warnings if the xmlrpcmaxservertimedifference configuration setting isn't set - which will mostly be the case.

Now they say that you can enter whatever you like. I also removed a bunch of helpfiles that aren't used any more.
(cherry picked from commit 6572a552)

Instead, generate a list of users who we could not send e-mail to, and display this to the uploaded, with more detailed reasons in the server error log.

Also, put a line in the .htaccess file to turn allow_call_time_pass_reference off. This way we'll never be caught by this issue again, not because php will not warn about it, but because developers will see these types of problems and fix them.

Use it in check_dir_exists, to set the permissions of directories created in dataroot.

Directories used to be created 0777, which is unnecessary unless the user is on shared hosting and needs to download their dataroot at some point later (which they will do for backup purposes).

This is so that the same query will be run, and we can guarantee that the pieform will be available so processing can occur.

This is a bit of a hack. It would be better to do the user search results in one big form, and toggle on the submit button pressed to work out what to do.

Make sure the default notification type for admin notifications is 'none', by correcting what the User class thinks the default is. Fixes #2062.

No need to clean up the text of a textbox on form submission - the WYSIWYG pieform element already does this for us. Fixes #2060.

* Make the loading box for AJAX stuff not take up the entire top of the page when it is visible
* Show the radio buttons on the view editor to allow people to edit views in ie6
* Remove the border from around radio buttons that isn't necessary

* The fieldsets are not collapsible in IE7 any more. I've narrowed down the problem to an IE7 issue with running javascript that has been inserted via innerHTML. It's going to be too much work to make pieforms work around it for now, so sorry IE - you lose.
* IE doesn't seem to understand the meaning of 'float', so make a table have auto width instead of 95% so that a float doesn't affect the position of the table.

Prevent more than one tag control appearing for the 'create folder' form - basically the same fix as for 144adb0a.

Don't do it by IDs however, because on the My Files page both tag inputs have the same ID. That will only end in pain. So for now, back to .parentNode hacks.

Allow the maximum time difference between servers doing XMLRPC communication to be configured. Fixes #1963.

The setting is called xmlrpcmaxservertimedifference. I can't be arsed putting a default in config-dist.php because people shouldn't use it anyway.

When a file is selected to attach to view feedback, disable and uncheck the 'make public' checkbox. Fixes #1938.

Ensure that when an error occurs on the profile form, the fieldset it occurs in doesn't get shown below the actual tabbed interface.

This problem happens because pieforms refuses to collapse fieldsets with errors in them (rightly, so people can see their mistakes).

The fix _might_ break some stuff, like specifying which tab to show on page load.

Don't always show the 'lose your changes' prompt when clicking 'view profile' from the profile page.

It's now only shown if you actually change a field, however:

* The change logic is simple - it's an 'onchange' on the fields themselves, so do not take into account if you make a change and revert it
* It doesn't work for the WYSIWYG boxes, they don't seem to fire onchanges. Would need another way to deal with this

Prevent multipe 'show my tags' lines appearing when uploading more than one file in My Files. Fixes #2029

fixing bug in upgrade where version wasn't bumped and plugins were trying to be installed unnecessarily

The old theme used to do this, somehow it has stopped since the new theme landed.