GitLab

Aaron Wells authored Jun 09, 2014 and Robert Lyon committed Jul 01, 2014

Old format: $CFG->plugin->blocktype->clippy->agent = 'merlin';
New format: $CFG->plugin_blocktype_clippy_agent = 'merlin';

The old format caused a strict standards warning.

Change-Id: I8ae2735ea3d3df913c0527bae7771e6f01dc82ca

Bug 1298646: No point in adding columns to the interaction_forum_post table
just to immediately drop them again.

Also, there were some lingering "accesstype IS NULL" checks in the elasticsearch
access queries, which should have been removed along with the "accesstype != objectionable"
that they were previously parenthetical with.

And, the artefact_access table doesn't need to accept "objectionable" as 
an accesstype enum value anymore.

Change-Id: I961f15e98eb8aab95e4e5b16af223eb61588f671
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

- Created 'objectionable' table
- Migrated existing objectionable records to a new table
- Added is_objectionable() method to View class
- Fixed can_view_view() and elasticsearch to use new table
- Fixed artefact.tpl style to match view page when displaying "Not objectionable" form
- Make forum reports use new 'objectionable' table

Change-Id: Ib3759e86c4003216ad57f3cf68911b13e50e9c67
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

- Also includes fix to show profile tagged blogpost in profile block
with correct blog id

Change-Id: I5b6a3b844ad98b8c4bdb3fc02ebc4ae12af32847
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Yuliya Bozhko authored Apr 24, 2014 and Robert Lyon committed May 09, 2014

Fixes in this patch:

- Moved artefact.php to artefacts directory to separate it from pages.
- Fixed reference to a wrong 'artefactonlyviewableinview' string.
- Removed add_to_render_path() and its calls which have no purpose at all.
- Removed 'artefact_parent_cache' table.
- Removed cron jobs related to 'artefact_parent_cache' from DB.
- Added 'path' column in 'artefact' table to easier calculate hierarchy.
- Added ArtefactTest.php for artefacts unit tests

Change-Id: Ia14cd85b94c32a950354446ee3565bd2964c625c
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

Bug 1281847

Change-Id: I8c87b77af8e42f2d405389c07b5b3bf2e8adbd44

group_search_user() in elasticsearch now passes the correct parameters
to the internal search plugin.

Change-Id: Ic26ea9b065b590a65ec4393f32fde41cdde7a52f
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Added hidden "Results" headings to search results for group Members and
Find friends which are focused when an AJAX search completes. Focuses
existing results display for elasticsearch.

Change-Id: I330e0da832f39cc16fd550c57be2ba5848e2d913
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Change-Id: I283f921d677605409d19b2490c6f2b9b79a28529
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- TO DO: will need to make sure that the results returned by public
search are allowed to be seen by the public

Change-Id: I1787bd1ba0f26d5f7ea86d5d7f1562987f98381c
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Elasticsearch will now index forums / forum posts as access[general] = public
rather than access[general] = none if the forum is part of a public
group.

Change-Id: I9c269fd290c52053c4ebae9f077556524b908bc5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This contains the mysql version of a db call used to get most 'open'
access type.

This patch will need to have https://reviews.mahara.org/#/c/2777/


working first before this can be tested in mysql

Change-Id: I99b55105eb4ffb7c314f6a5a05ba5e2a96cc38f1
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Thinking of privacy issues here - when should the users showup on
search results.

This patch allows users to show up based on the access of their
profile page (accesstypes: public, loggedin, friends) and whether
'Show users in public search' is set or not.

Normally all profile pages are accessible by logged in users - but
this can be altered if 'Logged-in profile access' is unchecked and
users remove the access off their profile page.

Change-Id: I4daa8cb2812bddb231ba489dfeefb4843b653d40
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Add new option to pieforms element, 'hiddenlabel', which adds the class
'accessible-hidden' to the element's label. Used this setting in the
universal search form for both internal and elasticsearch plugins.

Change-Id: Ie9c35a40b5aa818368ee2bd784d9f00d8592a465
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Tabs in elasticsearch page should now have "tab" and "tab selected" hidden
text to match the other in-page tabs in the site. Disabled tabs now have
hidden text "tab disabled".

Change-Id: Ief614d02fc286935c8f5e75341593542f4c5e208
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Need to let mahara elasticsearch respect the shards/replicas settings
set in ElasticSearch server

Change-Id: Idafcb87ebf1d01f97b2671a3eeee9c6d15a60093
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

All places where the profile picture is used should now have the new
profileimagetext string as the alt attribute, except where the
profile picture links to the "Edit profile picture" section

Change-Id: Ic0105ffb6612077954ee7bfe78aedd071b9c8a66
Signed-off-by: Jono Mingard <reason.koan@gmail.com>
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Currently the getConnection() in Elastica/Client.php can give false
positive and also throws error if no connection.

What is needed is a true/false check to allow for things like notice
feedback on extensions page or giving a warning when switching to
'elasticsearch' on site options page when it is unreachable.

Change-Id: I43506f03b943d79eb019d39fe794037fc50bd05a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I8de168c7e8e345d7d3028af49f21b7e07c6cc9be
Signed-off-by: Ghada El-Zoghbi <ghada@catalyst-au.net>

Ghada El-Zoghbi authored Oct 09, 2013 and Robert Lyon committed Nov 18, 2013

Rebasing change - merging conflicts:

	htdocs/search/elasticsearch/lib.php

Change-Id: Ieb202b23eb9bc4521916e32c96266aadf96de16e
Signed-off-by: Ghada El-Zoghbi <ghada@catalyst-au.net>

- items in group -> files not being found if they are not attached to
a view

- added code so that unattached group artefacts can be checked against
the artefact_access_role table (currently only used for group
artefacts) to see what roles they can be viewed by

Change-Id: I17eb03241e10e44460c0596c3d982c00dd39f336
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug1246553: When cleaning the query, replace the special characters with a space. This separates the tokens instead of concatenating them.

Change-Id: I4f367498efec95cecc9f90cee30d7aad5185c956
Signed-off-by: Ghada El-Zoghbi <ghada@catalyst-au.net>

Access for 'all' is not getting found for groups.  Explicitly setting the 'member' and 'admin' access for the group.

Change-Id: Iae37087d0ffc7df50fad9d62a2264b474d5a1b4e
Signed-off-by: Ghada El-Zoghbi <ghada@catalyst-au.net>

- also fixed problem where the Artefact types hierarchy was not being
saved

Change-Id: I7af217cff7138aef25b6e9cf5bb9527144477da4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

For when the $USER = record owner these titles link places where they
can be edited

- Journals : should work for both singular and multiple journals
- Resumes : the different artefact types should link to correct pages
in that section
- Plans / tasks : should link to the plan's task list page

also added in missing 'audio' option

Change-Id: I3002ff9087ff7c3998206ded5146be69dd367b1a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- including fixing hard coded lang string

Change-Id: Ied8163ac94711ef74555d820a9d3493dfb7a50bc
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Robert Lyon authored Sep 30, 2013 and Aaron Wells committed Oct 14, 2013

- have added this as a separate patch in case it is not needed

Change-Id: I87378a0d831727c405cc6135ba6f6e5e4a722813
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- have updated copyright for the pages that had existing copyright
notices (except for the lib/pieforms/ section as i'm not too sure if
that needs changing as it is a different Catalyst IT product)

Change-Id: I11c65ad26cb9cd856cf16b1dccbd4223ba086645
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Bug1237187

Change-Id: Ic6caf6179807d3a8bca4a40ea8069886de673c35

Fixing small language string problems prior to
the RC for 1.8.

Change-Id: Iadf84c061a8de55b67f1ae6bdc97dc650b067cee
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

- also problem with dirty changes effecting things also

- This was happening with the search box on the elasticsearch page
but not with the one in banner of page

Change-Id: I01a6c7251e21e02c640c466ff60a9eaeed03c28f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1225821: These elasticsearch types weren't respecting the
"deleted" flag on their source table:
 - group
 - interaction_forum_post
 - interaction_instance

Change-Id: I39d0b0c83db2384875753113b51b94cf1c29d304

Made minor lang string fixes that don't require
new lang strings and corrected HTML for link in
pluginconfig.analyzer.html

Change-Id: I17027839de80a1a7faf17e0fc30017dec3b9182d
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

Bug1217126
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>
Change-Id: I084d88eb9c638e52a12b2dea634ba94f07c3c824

- rebasing change

Change-Id: I4c262c0a22b75a3f9de6d43569765f65ee32c555