Skip to content

GitLab

Switch branch/tag
  1. 19 Jul, 2018 1 commit
    • Rebecca Blundell's avatar
      Bug 1760732: Add warning for upgrade of configurable themes · 8cac996b
      Rebecca Blundell authored and Robert Lyon's avatar Robert Lyon committed 
      Add 'customthemeupdate' flags for any institution to the
institution_config table if:
- the upgrade is from 16.10 or before
- and the institution is using a configurable theme

If there are institutions with 'customthemeupdate' set we add a warning
that the institution settings need to be re-saved.

Once the settings for an institution have been re-saved we clear the
flag for that institution

Steps to test:
1) Have a 16.04 version site
2) Create three institutions, two with a configurable themes
3) Checkout the patch and run upgrade
4) On clicking 'Continue' you should see the warning message
5) On going to Admin dashboard you should see message there also
6) Edit / save one of the institions
7) Confirm that institution is not listed
8) Do for the other and see warning now gone

behatnotneeded

Change-Id: I844d8e8bcb9be81a29f36cb101da1c61b41b10a9
      8cac996b
  3. 19 Jun, 2018 1 commit
  5. 17 Jun, 2018 1 commit
  7. 15 Jun, 2018 1 commit
  9. 20 May, 2018 1 commit
    • Robert Lyon's avatar
      Bug 1763163: record who has been given what page for one time copy · 1dcaef85
      Robert Lyon authored 
      

This changes the parent patch a bit. Instead of recording on the view
table if a page is able to be copied to existing group members we
insetad record in a new existing copy table if a group page/collection
has been copied to a member and if not make the copy.

We've also made the switch a slide switch, eg when switching it to
'Yes' it does the task on save and then switches back to 'No'.

This means at a later time if set to 'Yes' again it will do the copying
again and give any newer members a copy of all pages/collections as
well as give older members copies of any newer pages / collections /
collection pages since the previous switching to 'No'

Note: Currently adding new collection pages to older members will only
add the pages as singular pages to their portfolio.

behatnotneeded

Change-Id: Ia22d8138d80ec5fdb5a401de7289b256f9e5fc69
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      1dcaef85
  11. 16 May, 2018 1 commit
    • Robert Scally's avatar
      Bug 1763163: Copy group portfolios automatically to existing group members · 01af3dab
      Robert Scally authored and Robert Lyon's avatar Robert Lyon committed 
      A portfolio shall be copied automatically to existing regular group 
members, i.e. excluding group tutors and administrators, when
setting up the sharing permissions for the portfolio and selecting the
copying option in "Advanced options".

When new people are added to the group, the portfolio is not automatically
copied to their accounts as they were not in the group when the copying
was turned on.

behatnotneeded

Change-Id: I5f706056e3c53f1edc8bcb86cfd41bad1df0185b
      01af3dab
  13. 18 Apr, 2018 1 commit
    • Maria Sorica's avatar
      Bug 1723961: Allow plan blocktypes to display more than one plan · bc40a45f
      Maria Sorica authored and Robert Lyon's avatar Robert Lyon committed 
      1. Added a details link for each plan in the blocktype as well.
2. On site update, the existing plan blocktypes will be updated
to be able to contain more than plan.
3. Made task pagination work on blocktypes with
multiple plans.

behatnotneeded

Change-Id: I4b462f447489eb16d43fd40cfa552825c5178a47
      bc40a45f
  15. 19 Mar, 2018 1 commit
  17. 08 Mar, 2018 1 commit
  19. 07 Mar, 2018 1 commit
  21. 02 Mar, 2018 1 commit
    • Robert Lyon's avatar
      Bug 1443284: Allow an unsubscribe link for watchlist emails · 17131a35
      Robert Lyon authored 
      

This patch:
- adds an 'unsubscribetoken' column to usr_watchlist_view table
 (if we want to unsubscribe other messages we'd need to add an
'unsubscribetoken' to the relevant table)
- records the token when one watches the view
- sends email with unsubscribe link with message type and token to
avoid exposing any user data
- link goes to unsubscribe.php page and either unsubscribes user or
gives generic warning

Currently only working for watchlist notifications being sent via
email/email digest

Change-Id: I823249108f521faaefe3435f03b84ddf73e2d360
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      17131a35
  23. 23 Feb, 2018 1 commit
    • Glenn Walbran's avatar
      Bug 1729079: Create a mechanism to build manual links · dbf1ef2b
      Glenn Walbran authored and Robert Lyon's avatar Robert Lyon committed 
      This commits adds a mechanism that will build links to the manual pages
such that:

- user's language is used if manual exists in that language, else en
- the manual for this mahara/series is used

The key -> manual page map will need to be populated and these links added to
pages.

Change-Id: Id7871395821dce660841341dda200f231e75de16
      dbf1ef2b
  25. 22 Feb, 2018 3 commits
  27. 16 Feb, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1734178: allow user to delete own account · 9837f182
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      added settings

- institution level: reviewselfdeletion
    0 if the institution does not require approval
      from an admin to delete an account
    1 if the institution requires an admin to approve
      account deletion requests from users
    if not set, it takes the value from the site's
    default

- site level: defaultreviewselfdeletion
  (Site options->User Settings -> Review account before self-deletion)
    1 if the site's default is requiring approval
    null otherwise

Account deletion by a user

when a user accesses to the account settings, a
'Delete account' button is displayed.

This will:
- If the user belongs to an institution that requires
  approval (or does not have the settings but the site
  requires approval by default)
    then a notification will be sent to the admins
    of the institutions that require approval that
    the user belongs to
- if the user belongs to institutions and none of them
  require approval (or does not have the setting
  but the site does not require approval by default)
    then the account is deleted
- if the user does not belong to any institution
    then the action will depend on the setting of
    the 'mahara' institution or sites default if
    'mahara' doesn't have the setting

Approval by institution admins

An institution admin can see the pending deletion
requests in Admin menu-> Institution -> Pending deletions
After approving/denying a request, the user
that requested the account deletion will receive
a notification

behatnotneeded
Change-Id: I4ccd9c798cab065ec557eaddf7dfc3a51920b6d0
      9837f182
  29. 15 Feb, 2018 1 commit
  31. 12 Feb, 2018 1 commit
  33. 05 Feb, 2018 1 commit
    • Maria Sorica's avatar
      Bug 1734174: Add the after login privacy page · 44a6284e
      Maria Sorica authored 
      Upon login, if the user has not yet agreed to the most
recent Privacy statement versions, he will be redirected
to this page.

On install admin user accepts default privacy

behatnotneeded

Change-Id: I6afc3d4d4db0676782a8b1501a962862108eab6b
      44a6284e
  35. 24 Jan, 2018 2 commits
  37. 19 Jan, 2018 2 commits
  39. 09 Jan, 2018 3 commits
  41. 03 Jan, 2018 1 commit
  43. 16 Nov, 2017 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1572825: added Voki html filter for embed code · 207889a5
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      Added new html custom filter to allow
voki embed code with javascript tags.

issue with the creation/edition of blocks:

Voki embed code its a javascript code that loads
js functions from a remote file and makes a call to a
AC_Voki_Embed() function

parameters:

function AC_Voki_Embed (width, height, chsm, sc,
transparent, bgcolor, returnFlag, playerType)

The number of parameter makes the difference between
old and new voki code. The old one will have only 7,
the new one will have one more.

The new embed code will have playerType = 1
The function uses an XMLHttpRequest to obtain the
new embed code. When we are loading the page,
there is no problem. But when we are editing or
creating the block, the the connection with the object
gets lost and the embed code is never loaded.
Solution found: reload the page after editing or adding
a block with new voki code.

The old voki code can have
returnFlag = 1 will return a string with the code
returnFlag = 0 will load the embed code in the page (by default)
In this last case, after the function creates the embed code,
it will call document.write('embed code')
if we are loading a page with the embed code, we have no problem
but if we have the page already loaded and we are editing the block
or creating it, the document.write will replace all the html
with the embed code.
Solution found: change parameter of the function so it returns
the code instead, then manually add it in the correct place
of the html.

behatnotneeded

Change-Id: Ieed00b6c6887715b707b8123082a1312f3db1d9c
      207889a5
  45. 30 Oct, 2017 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1660237: removed old mobile api · d7018426
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed 
      removed code from htdocs/api/module/ files and replace it with a json reply error message.
removed the 'allowmobileuploads' config variable since it is only used by the old mobile api.
removed the 'mobileuploadtoken' values in usr_account_preferences since they are only used by old mobile api. The new mahara mobile uses external_tokens table to store its access tokens.

behatnotneeded

Change-Id: I02e94079fc83aa6a81534b70446f7e8ab2ebd7a4
      d7018426
  47. 27 Oct, 2017 1 commit
    • Cecilia Vela Gurovic's avatar
      Security Bug 1701978: fix session cookie issues · d02855fc
      Cecilia Vela Gurovic authored 
      1. when a user logs in it clears any obsolete
   usr_session cookies for the user
2. recording the user-agent of the session
   and if it changes to prompt the user to
   login again
3. when self adding / editing email address(es)
   send 2 emails
	- one to the new email address asking user to confirm address
	- and one to the primary email address to alert user
	that a new email is being added to their account and
	if this is bad how to contact their admin about the problem.

behatnotneeded
Change-Id: Ia44b66cf831abd553b72aa8b1d58d2a2634863b8
      d02855fc
  49. 29 Sep, 2017 1 commit
  51. 26 Sep, 2017 1 commit
  53. 24 Sep, 2017 1 commit
  55. 22 Sep, 2017 2 commits
  57. 20 Sep, 2017 1 commit
  59. 09 Sep, 2017 1 commit
    • Robert Lyon's avatar
      Bug 1692385: Adjusting the event_log table · ebd928b1
      Robert Lyon authored 
      

Add 5 new new columns to event_log table make searching over the
data easier and also record the id of any parent/related info as well

Eg, if one deletes an image block from a page we now record:
id - the event id
resourceid - the block id
resourcetype - the blocktype, eg image
parentresourceid - the id of the parent, eg view id
parentresourcetype - the type of parent, eg 'view'

Because we would not be able to find related view info from just the
block id anymore.

Also added the ability to index and search over event information in
elasticsearch search type event_log

Change-Id: I280c1c75c35a6c58f42d8acb36cf5c24c70b902d
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      ebd928b1
  61. 03 Sep, 2017 1 commit
  63. 29 Aug, 2017 1 commit
  65. 27 Jul, 2017 1 commit