Mike Kelly authored Nov 19, 2013 and Robert Lyon committed Jan 08, 2014

Change-Id: I1daef151b72a04469b8e78ebd0a487639b9843c1
Signed-off-by: Mike Kelly <m.f.kelly@arts.ac.uk>

also display number of views using the skin to delete

Change-Id: I64faac110c8caa84ef28195368afdfbec8b0bc76
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Robert Lyon authored Dec 31, 2013 and Aaron Wells committed Jan 07, 2014

Taking Melissa Newman's code snippets from bug and adapting it for core
- <figure> and <figcaption> aren't semantically accurate in this context, so using <div> instead
- Adding a block instance config checkbox setting to allow to turn it on/off

Change-Id: I63ea2ccda0de2243782cc232e3ecb352ecd98d95
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

If you set $cfg->renamecopies = false, copies can still have a
number added to the end of them, which is a little counterintuitive
because it's still a kind of renaming.

Change-Id: I97e512c21d6e28417062eb3429b3accd92297e1d

Jono Mingard authored Jan 03, 2014 and Robert Lyon committed Jan 06, 2014

In /artefact/internal/index.php and /skin/design.php the in-page tabs now
focus their first focusable child when the current tab is changed. Using
jQuery since MochiKit doesn't have an easy way to select all input-like
elements.

Change-Id: I1af75a9fb7464ad3bf2583e169d6f97a9605f688
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Expandable fields (accessed by "Add" and "Edit" buttons) in Resume now
set focus to their first focusable child when opened and return focus
to the Add/Edit button when cancelled.

Change-Id: Ia1a4f5c5d3ce79ed416a7d146b91fef21f8c0744
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Bug #1266317

Change-Id: Ief7c8c5d2aef455d61e78feb5d3c7571d517c830
Signed-off-by: Mike Kelly <m.f.kelly@arts.ac.uk>

Bug #1266317

when reading from and writing to usr_custom_layout table

Change-Id: I27d83d9a7e76f250cfc903198567d2341168cacc
Signed-off-by: Mike Kelly <m.f.kelly@arts.ac.uk>

Mike Kelly authored Nov 19, 2013 and Robert Lyon committed Jan 06, 2014

Bug #1266317

Group pages, site and institution pages were set as having usr = 0 in
usr_custom_layout because the view owner is null.

Fix by adding group column to table, foreign keyed to group table.

usr column and group column have to be changed to allow null values, and
to have null as default values.

When saving a custom layout, check context, then set usr and group
values accordingly. 
e.g. 
usr = 5, group = null 
usr = null, group = 321
In the case of site and institution pages:
usr = null, group = null

Change-Id: Id42ebcc543d29ee2455aef73227b57c569171385
Signed-off-by: Mike Kelly <m.f.kelly@arts.ac.uk>

The changing of the tabs from <input> to <button> broke the hover
state of the cursor.

Change-Id: Ia85a91fa0e08f49df51934c65ee77757712e2ca7
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Changed showhideComposite() to add the requested content (description and
attachments) to the cell containing the title of the composite, rather than
adding a new row to the table.
This means that in places such as the Education history table, clicking on the
qualification will open the description immediately below the title instead
of creating a separate row.

Change-Id: Id05bf73e2932108abd9979359bb7f64e6b3ca3fc
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

The "Set default" and "Delete selected profile pictures" buttons still had their
tabindex set to 2, so that has been removed.

Change-Id: Ic9255f12ea7be40b8bc22867527de89231057cfe
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

When building the contextual help box, focus is set to the close button
(which now has descriptive alt text)
The help box is now inserted into the HTML immediately after the help
icon that was clicked (or after its parent if the parent is a heading)
so that the document still appears in a logical order to screen readers.

Change-Id: Ib8a10e2766038cfd32b1c6c76883f9642255639b
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Added hidden text to all in-page tabs to show that a) they are
tabs and b) which one is selected. This applies to tabs defined
in templates and tabs generated with JavaScript.

Change-Id: I20969547081ad4b39fc698a24f8987be9a08508c
Signed-off-by: Jono Mingard <reason.koan@gmail.com>
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Change incorrect definition of RESUME_SUBPAGE so that the license
tab gets the current-tab class when it's selected.

Change-Id: I1f225b496167801c5a0bc491574d82c35d105a3a
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Changed icons in Inbox blocktype and Inbox page to have consistent,
descriptive alt text.
Added CSS for hidden elements that are still read out by screen
readers and used this to add hidden "Unread" text to unread
notifications in Inbox blocktype.

Change-Id: I1bfb3826474d6bb06544872c600bc5f966acac67
Signed-off-by: Jono Mingard <reason.koan@gmail.com>
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

All places where the profile picture is used should now have the new
profileimagetext string as the alt attribute, except where the
profile picture links to the "Edit profile picture" section

Change-Id: Ic0105ffb6612077954ee7bfe78aedd071b9c8a66
Signed-off-by: Jono Mingard <reason.koan@gmail.com>
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Change-Id: Ied2c3a8fee37d0a8eb218a59ab8095fab953fe24
Signed-off-by: Kristina D.C. Hoeppner <kristina@catalyst.net.nz>

Bug #1255780

When clicking the 'Copy a collection' button on the
Portfolio -> Collections page the list of copyable pages is sorted by
collection name rather than page name to make it easier to see what pages are
in the collection that you are about to copy.

Also the subheading highlighted is 'Collections' instead of 'Pages'.

When clicking the 'Copy a page' link in Portfolio -> Pages things
should work like before.

- TODO: possibly limit each copyable collection to have one 'Copy
collection' button and have the alternating row colours toggle for
each collection rather than just each row.

Change-Id: I4b9786ba95404e03f44039cacb6e6b4bf6a4b0d6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The field is currently not being used but because the install.php file
had the id column in it for v1.8 it means sites installed with 1.8
have the column but sites upgraded to 1.8 do not.

Change-Id: If1e52cf68ad18ce730fd2e9be3abf8684a94368d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When the 'enabled' option is clicked it opens multiple fieldsets
so we need to get the js to do focus on the first field in the first
fieldset. As it is one-off code we can just use the id of the field to
do the focus.

Change-Id: I4f87b5f35b5dc6aa027ab2fe6203e6d8f74b14ef
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Changes collapsible fieldsets to focus their first child input (or
<select> or <textarea> or whatever) when they are expanded.

Change-Id: I97b5b36321d4ac5208602c21593297a7d1e87de7
Signed-off-by: Jono Mingard <reason.koan@gmail.com>

Requires upgrading the plugin to work on administration page
then one can set the sort order on Extensions -> file/folder ->
configuration
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I24cda8e7361fc57f66bb391b3cf533c904ba2c38

Changed pieforms to set a tabindex of 0 by default (rather than starting
at 1 and incrementing for each successive form)
Removed other explicit tabindex attributes (in login forms)

Change-Id: I40ccc95d4437764742391a27ae4d89485d9921b4
Signed-off-by: Jono Mingard <reason.koan@gmail.com>

in Profile/Shared with me page

Change-Id: I675a8c9062da37e668cd27621993fb7474b08973
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Modified pieforms to put the asterisk marking a required form
field inside the label rather than outside to make required
fields accessible to screen readers.
Also reset the font weight for markers so their styling appears
the same.

Change-Id: I8bb5cb8c57c164f5c85392e8988760d0a34aaed3
Signed-off-by: Jono Mingard <reason.koan@gmail.com>

Bug 778254

Change-Id: I273b347070266d2229159f838d0f7a061c63250b

Bug 1262040: Since it turns out these methods don't do exactly
what their name suggests, it's a good idea to at least put a comment
on there

Change-Id: I1fd8138d004768a534072c0485144bba3ebee5d1

Older sites can end up with duplicate rows in the
blocktype_externalfeed_data for the same url. This causes problems if
the site is using latest mahara as it stops one being able to add
/edit a feed if there are duplicate rows for that feed's url.

Change-Id: I47ee3952dbe75b5643adf55105a9219a3e3e8cd9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

In the 1.8+ codebase there are only two places where both mysql and
postgres use CAST(). So I've tried altering the calls so that mysql
doens't need to use CAST().

This will probably need to be tested with a large data mysql db site
to see if any speed gains are made, and also the calls are still
working correctly.

All other places it is being used by postgres only
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I9eaf196d062ef2a62bfdae0df179281f3411c392

Robert Lyon authored Nov 26, 2013 and Aaron Wells committed Dec 17, 2013

Bug 1174623 For sites that have been upgraded from version 1.0 there are
some missing constraints and indexes on the artefact_access_usr,
artefact_access_role, artefact_attachment, group, grouptype_roles
and view_autocreate_grouptype tables.

Also some fields need to be adjusted to match the referenced field in
another table so that they can be used as a foreign key

Change-Id: Ifb8cd79d4fa9933be02f6086fb5dada18d47bfe2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Aaron Wells authored Dec 13, 2013 and Robert Lyon committed Dec 17, 2013

Bug 1261231

Change-Id: I82d8169e41dcca65c214fdfec954086eba8fc6c8

Changed profile picture string to include the user's name.
Added this string to profile pictures where the lack of alt text was
preventing the attached username from being read out by screen
readers

Change-Id: I6be98e4b6131d8c01c2384222edeec2349a7d0ac
Signed-off-by: Jono Mingard <reason.koan@gmail.com>

Gregor Anzelj authored Dec 09, 2013 and Robert Lyon committed Dec 16, 2013

Change-Id: I4bd3680e9866a3371b46de807e34712fa1029472
Signed-off-by: Gregor Anzelj <gregor.anzelj@gmail.com>

Bug 1070046: MySQL has an optional server config option, "MAX_JOIN_SIZE",
which throws an error if you try to run a SQL query that MySQL's strategizer
thinks will require it to evaluate more than MAX_JOIN_SIZE rows. This is
intended to prevent the user from accidentally running giant queries that
will never finish, but some Mahara queries (which are large but will finish)
can trip it. Adding SQL_BIG_SELECTS=1 tels it that our queries are *not*
accidentally large.

Change-Id: I6db4699ea765d3213d13eb93b8de098914db24e0

Bug 1261233: If you set the ratio to 0, you'll bounce someone
as soon as they hit bounces_min, regardless of what the sent/bounced
ratio is

Change-Id: Ibe8223054fa70ea27748d78b099afa079be7f900

Change-Id: I32cf198a8fa33a9e9773a752c6b32ce5fa079c7b
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

1. Add the begining of PHP file, call
JavascriptDetector::check_javascript();

2. Call JavascriptDetector::is_javascript_activated()
 or $SESSION->get('javascriptenabled') to get the current status.

3. Call JavascriptDetector::reset() when users logout.

Change-Id: Ia12e1678ae2f3f74f3b8e5fb2c0bfdd20d5ae906
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Bug 974855: It's not great that the helpfile doesn't actually contain the URL for your sitemap,
but we'd need to implement the ability to put parameters or variables into help files to make that happen.

Change-Id: I7cc414510ffe78432a4e21d61a829f67ff1d9929

- have got the deny request, remove friend, send message and request
friend options remembering the pagination

- I also altered the code in some places to match the coding layout
in others.

The offset variable gets passed through to form so on return you end
up on correct pagination page rather than beginning of list

Change-Id: I043240f2be97431b2db2376999ec551569a37e82
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>