Mike Kelly authored Nov 19, 2013 and Robert Lyon committed Jan 08, 2014

Change-Id: I1daef151b72a04469b8e78ebd0a487639b9843c1
Signed-off-by: Mike Kelly <m.f.kelly@arts.ac.uk>

also display number of views using the skin to delete

Change-Id: I64faac110c8caa84ef28195368afdfbec8b0bc76
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

If you set $cfg->renamecopies = false, copies can still have a
number added to the end of them, which is a little counterintuitive
because it's still a kind of renaming.

Change-Id: I97e512c21d6e28417062eb3429b3accd92297e1d

Bug #1266317

Change-Id: Ief7c8c5d2aef455d61e78feb5d3c7571d517c830
Signed-off-by: Mike Kelly <m.f.kelly@arts.ac.uk>

Bug #1266317

when reading from and writing to usr_custom_layout table

Change-Id: I27d83d9a7e76f250cfc903198567d2341168cacc
Signed-off-by: Mike Kelly <m.f.kelly@arts.ac.uk>

Mike Kelly authored Nov 19, 2013 and Robert Lyon committed Jan 06, 2014

Bug #1266317

Group pages, site and institution pages were set as having usr = 0 in
usr_custom_layout because the view owner is null.

Fix by adding group column to table, foreign keyed to group table.

usr column and group column have to be changed to allow null values, and
to have null as default values.

When saving a custom layout, check context, then set usr and group
values accordingly. 
e.g. 
usr = 5, group = null 
usr = null, group = 321
In the case of site and institution pages:
usr = null, group = null

Change-Id: Id42ebcc543d29ee2455aef73227b57c569171385
Signed-off-by: Mike Kelly <m.f.kelly@arts.ac.uk>

When building the contextual help box, focus is set to the close button
(which now has descriptive alt text)
The help box is now inserted into the HTML immediately after the help
icon that was clicked (or after its parent if the parent is a heading)
so that the document still appears in a logical order to screen readers.

Change-Id: Ib8a10e2766038cfd32b1c6c76883f9642255639b
Signed-off-by: Jono Mingard <jonom@catalyst.net.nz>

Bug #1255780

When clicking the 'Copy a collection' button on the
Portfolio -> Collections page the list of copyable pages is sorted by
collection name rather than page name to make it easier to see what pages are
in the collection that you are about to copy.

Also the subheading highlighted is 'Collections' instead of 'Pages'.

When clicking the 'Copy a page' link in Portfolio -> Pages things
should work like before.

- TODO: possibly limit each copyable collection to have one 'Copy
collection' button and have the alternating row colours toggle for
each collection rather than just each row.

Change-Id: I4b9786ba95404e03f44039cacb6e6b4bf6a4b0d6
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The field is currently not being used but because the install.php file
had the id column in it for v1.8 it means sites installed with 1.8
have the column but sites upgraded to 1.8 do not.

Change-Id: If1e52cf68ad18ce730fd2e9be3abf8684a94368d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Changes collapsible fieldsets to focus their first child input (or
<select> or <textarea> or whatever) when they are expanded.

Change-Id: I97b5b36321d4ac5208602c21593297a7d1e87de7
Signed-off-by: Jono Mingard <reason.koan@gmail.com>

Changed pieforms to set a tabindex of 0 by default (rather than starting
at 1 and incrementing for each successive form)
Removed other explicit tabindex attributes (in login forms)

Change-Id: I40ccc95d4437764742391a27ae4d89485d9921b4
Signed-off-by: Jono Mingard <reason.koan@gmail.com>

Modified pieforms to put the asterisk marking a required form
field inside the label rather than outside to make required
fields accessible to screen readers.
Also reset the font weight for markers so their styling appears
the same.

Change-Id: I8bb5cb8c57c164f5c85392e8988760d0a34aaed3
Signed-off-by: Jono Mingard <reason.koan@gmail.com>

Bug 778254

Change-Id: I273b347070266d2229159f838d0f7a061c63250b

Older sites can end up with duplicate rows in the
blocktype_externalfeed_data for the same url. This causes problems if
the site is using latest mahara as it stops one being able to add
/edit a feed if there are duplicate rows for that feed's url.

Change-Id: I47ee3952dbe75b5643adf55105a9219a3e3e8cd9
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

In the 1.8+ codebase there are only two places where both mysql and
postgres use CAST(). So I've tried altering the calls so that mysql
doens't need to use CAST().

This will probably need to be tested with a large data mysql db site
to see if any speed gains are made, and also the calls are still
working correctly.

All other places it is being used by postgres only
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I9eaf196d062ef2a62bfdae0df179281f3411c392

Robert Lyon authored Nov 26, 2013 and Aaron Wells committed Dec 17, 2013

Bug 1174623 For sites that have been upgraded from version 1.0 there are
some missing constraints and indexes on the artefact_access_usr,
artefact_access_role, artefact_attachment, group, grouptype_roles
and view_autocreate_grouptype tables.

Also some fields need to be adjusted to match the referenced field in
another table so that they can be used as a foreign key

Change-Id: Ifb8cd79d4fa9933be02f6086fb5dada18d47bfe2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Aaron Wells authored Dec 13, 2013 and Robert Lyon committed Dec 17, 2013

Bug 1261231

Change-Id: I82d8169e41dcca65c214fdfec954086eba8fc6c8

Gregor Anzelj authored Dec 09, 2013 and Robert Lyon committed Dec 16, 2013

Change-Id: I4bd3680e9866a3371b46de807e34712fa1029472
Signed-off-by: Gregor Anzelj <gregor.anzelj@gmail.com>

Bug 1070046: MySQL has an optional server config option, "MAX_JOIN_SIZE",
which throws an error if you try to run a SQL query that MySQL's strategizer
thinks will require it to evaluate more than MAX_JOIN_SIZE rows. This is
intended to prevent the user from accidentally running giant queries that
will never finish, but some Mahara queries (which are large but will finish)
can trip it. Adding SQL_BIG_SELECTS=1 tels it that our queries are *not*
accidentally large.

Change-Id: I6db4699ea765d3213d13eb93b8de098914db24e0

Bug 1261233: If you set the ratio to 0, you'll bounce someone
as soon as they hit bounces_min, regardless of what the sent/bounced
ratio is

Change-Id: Ibe8223054fa70ea27748d78b099afa079be7f900

Change-Id: I32cf198a8fa33a9e9773a752c6b32ce5fa079c7b
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

1. Add the begining of PHP file, call
JavascriptDetector::check_javascript();

2. Call JavascriptDetector::is_javascript_activated()
 or $SESSION->get('javascriptenabled') to get the current status.

3. Call JavascriptDetector::reset() when users logout.

Change-Id: Ia12e1678ae2f3f74f3b8e5fb2c0bfdd20d5ae906
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

- have got the deny request, remove friend, send message and request
friend options remembering the pagination

- I also altered the code in some places to match the coding layout
in others.

The offset variable gets passed through to form so on return you end
up on correct pagination page rather than beginning of list

Change-Id: I043240f2be97431b2db2376999ec551569a37e82
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Son Nguyen authored Dec 12, 2012 and Robert Lyon committed Dec 10, 2013

When there are 3 pages to display and the current page is the
second, the link to the first page is missing. This patch fixes the
problem.

Change-Id: I18103086a0564b06c0a92b5821067da1b60f9108
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Bug 1247722: Note that the patches we'd applied to version 1.0.4 have all been
incorporated into 1.0.5. Hence the empty changes list in README.Mahara

Also, version 1.0.5 has the Pear Log class as a dependency, so I'm including that.

Change-Id: Ib57c19ebfbf1f5656adea70b282064e387482bae

Bug #1255378

This fundamentally changes the behavior of find_key_name(). Before, it only generated what the default name for the key would be, now it actually checks whether a key of that description exists in the DB and returns its actual name in the DB.

In core the method was only used by XMLDBGenerator in the methods for dropping or altering a key, so this change will actually make it more robust.

In theory, though, if there is third-party code relying on the current behavior of find_key_name(), they could have problems.

Change-Id: I0470422a6e6514af98beb83e884178ee7f341ccd

Bug 1246580: The customizations we had on our 5.1 version aren't necessary in 5.2.7

Change-Id: I9f62a82a659e0414535048678db818d02d83e751

Son Nguyen authored Nov 21, 2013 and Aaron Wells committed Nov 26, 2013

1. Add a new column 'last_processed_userid' into the table
activity_queue
2. Enable the notify_users() method to work with split user chunks
3. Modify the activity_process_queue() function to update the
activity_queue with the new process

Change-Id: Id404aa8e8fa6515cfeb557a4ea11c14c43771fe7
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

In some cases the $user->urlid may not be present - this checks for it
before accessing it otherwise it falls back to the $id to get info

Change-Id: I989e68321402f458b167879e994150213c3e4893
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Notify administrators (site and institution) when membership is full when a new user requests a membership.

Bug #1204699

Change-Id: I5459e14805307da3dfa3ca7d8791569670c8fd5d
Signed-off-by: Ghada El-Zoghbi <ghada@catalyst-au.net>

Change-Id: Id8b24afcd7dcfc315b1f62cf70e57de289ba784f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Added a button to click to view metadata of a skin
- currently limited to title, owner, creation date, modified date
and description.

The creation date and owner reflect who currently owns the skin.
 - so if the skin is imported it does not reflect the original creator
as this information is not currently recorded in skin export.

Change-Id: Ife7fdad2b613cd6a3c52252b90a46f869c665351
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

- option added v1.3 but not documented in the list of defaults that
are available

Change-Id: Ib6010e502ffdefe00d86856674fc54362fa41faa
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

The creation date was being set to null on edit.
I've added code to preserve the creation date
- and to add new one (last modifed date) if a
skin does not have one (been edited before the patch applied)

Change-Id: I5b66a0ff7dbefde4c35315b4749f1295205cba99
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This reverts commit 35a6a62a.

Change-Id: I5902b77157fdb8df7c73dba27921c832c69b338b

Change-Id: Ic554b94fa20f5978108b0c828c70834246c9c9c9
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Bug 1250256

Change-Id: Iefd489adb4f7d458d1e8b45727fab5509c61398b

Change-Id: Ie9389e1d061e720dc82f335f043dadee29459b27

if it is activated in config.php

The skins setting is added to Site config page as well

Change-Id: I4464867db90dc9fd34220b1d865fb5b3527ef168
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Bug1075760: reporting objectional material with no message doesn't get sent to admin with digest emails

Email digest table has a not null contraint for the message field:
1. Force the user to enter something in the objectionable comment.
2. Other areas: if a user enteres a message (i.e. in a forum)
which is made up of html (i.e. a smiley face),
the message gets 'cleaned' by stripping html tags.
This leaves it empty and fails when trying to insert into the
email digest table.
Clean the message with html2text instead of str_shorten_html.
3. As a last resort, before inserting into the email digest table,
make sure there is at least a space in the message field (if it's empty).

Change-Id: I05a77e0682017839b34e74241eefb98fb788eab5
Signed-off-by: Ghada El-Zoghbi <ghada@catalyst-au.net>