1. 15 Jun, 2015 1 commit
  2. 21 Apr, 2015 1 commit
  3. 03 Mar, 2015 1 commit
    • Nigel Cunningham's avatar
      (Bug1352028) Add a JSON progress bar for bulk operations. · 55a8deb8
      Nigel Cunningham authored
      This patch adds a JSON progress meter (I'll call it that to avoid confusion
      with progress bars) to the bulk uploading of users, groups and group
      memberships and the bulk export and import of users (LEAP), so the user can see
      the progress of the operation and not just the submit button changed to
      'Processing..' and whatever indication their browser gives while waiting for
      The bulk export and import are minor rewrites, replacing the old iframe based
      progress bar and the associated multiple pages and additional template file in
      the case of the bulk export, and the recursive redirect-to-self of the bulk
      To accomplish the display of the progress bar during the operation, we make the
      PHP session be closed (read only) except when changes need to be made. This is
      for the most part a straightforward change in session.php as it's the only
      direct accessor. In other places, we replace direct accessing of the session
      variable ($_SESSION) with use of the session class ($SESSION) so that it can
      reopen the session, make the change and close the session again.
      There is one more aspect to all of this: with previous behaviour, multiple
      requests for the same session would queue, taking the session lock in turn.
      After this patch is applied, they can proceed in parallel, allowing greater
      throughput. There is no additional locking requirement because the issues are
      the same as those already dealt with in allowing multiple PHP threads to
      process requests from different sessions at the same time.
      I have sought to make the progress meter nice and generic, so it can be used in
      the other bulk imports and exports too.
      Paradoxically, these changes don't just make the import seem to be faster, it
      actually is.. at least in the case of users and groups.
      Times for importing 1000 users, groups and memberships, averaged over 3 runs
      each (Wall time, not CPU time - but the relationship is the same).
                      Without Progress     With Progress
      Users                166s               155s
      Groups                85s                78s
      Memberships           20s                19s
      Change-Id: Iec15c57db32c77994edb80c71d65591de51a95e4
      Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
  4. 16 Feb, 2015 1 commit
  5. 15 Jan, 2015 1 commit
    • Aaron Wells's avatar
      Let "group pages" show pages by group members only · 469ef3c8
      Aaron Wells authored
      Bug 1411004: This patch adds an option to the "group
      pages" block, to limit the "pages shared with this
      group" and "collections shared..." sections so that
      they only show pages & collections authored by
      current members of the group
      Change-Id: I95185d61d384aa298fba065a96ccd635c3430ec5
  6. 19 Dec, 2014 1 commit
  7. 11 Dec, 2014 1 commit
  8. 06 Oct, 2014 1 commit
  9. 18 Sep, 2014 1 commit
    • Robert Lyon's avatar
      The archiving of submitted pages/collections from groups (Bug #1335670) · 5c57b565
      Robert Lyon authored
      This patch contains:
      - The export queue system where pages/collections on release from
      submission are added to the export queue table ready to be archived.
      - The export queue admin page showing what is in the queue to be
      exported. The cron runs every 6 minutes. Queue items failed to export
      are also shown here.
      - The archive list admin page, where one can download the generated
      leap2a files for the archived submissions.
      In this patch you should be able to add things to the export queue by
      either releasing a sumbission on a group that has 'archive
      submissions' option ticked. This will add the archive to that archived
      submission page, or you can also run a leap2a export from portfolio
      export which will add the export queue and send you an email once the
      export is done.
      Things to note:
      - The is a server busy function that stops the export queue from
      running but I'm not too sure if the threshold is too low/high
      - The export queue tries to export the first 100 items each run but if
      resources are fine in handling that easily then the number could be
      higher but I'm not sure of what will be a good number.
      - Currently there is alsoe infrastructure like table columns for dealing
      with releasing submissions from external systems (eg moodle) but that
      functuionality is yet to be built.
      - The checking of server busy in MS windows untested - may need to
      just let MS ignore server busy check as there doesn't seem to be
      standard way to check this.
      Change-Id: If4c1d272e9c5d46fbf16b2ff73ceb2687c06ffd4
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
  10. 25 Aug, 2014 1 commit
  11. 01 Jul, 2014 2 commits
    • Robert Lyon's avatar
      Allowing feedback notifications on group pages (Bug #1307247) · 3b0382ef
      Robert Lyon authored
      In this patch:
      - Changed the Group Edit 'General' section and added the 'Feedback
      notifications' options.
      - Changed the Group Edit 'General' section and altered the 'Shared
      page' option from tickbox to select options.
      - Changed the CommentFeedback to be able to notify multiple users in a
      - Changed the CommentFeedback to be able to send message in the
      institution lang if needed.
      - Adjusted group_get_editroles_options() to allow it to return a non
      associative array
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      Change-Id: Ia2e995c51aa08610945788e55c809b3c650dcd17
    • Son Nguyen's avatar
      Refactor the function group_get_user_groups(). Bug 1304053 · 1a9a4081
      Son Nguyen authored
       - Add function comment,
       - Make it compatible to old calls
       - Sort the list out of the queries to reduce the MYSQL queries
       - Set the sort default value when displaying the my group side bar
      Change-Id: I50decadcebe8a5cb38706809d70a784e6694c46d
      Signed-off-by: default avatarSon Nguyen <son.nguyen@catalyst.net.nz>
  12. 24 Jun, 2014 1 commit
  13. 09 Jun, 2014 1 commit
  14. 05 Jun, 2014 1 commit
  15. 04 Jun, 2014 1 commit
  16. 18 May, 2014 1 commit
  17. 08 Apr, 2014 1 commit
  18. 24 Mar, 2014 1 commit
  19. 19 Feb, 2014 1 commit
  20. 03 Feb, 2014 1 commit
  21. 24 Jan, 2014 1 commit
  22. 16 Jan, 2014 1 commit
  23. 13 Jan, 2014 1 commit
    • Aaron Wells's avatar
      Decoupling "copy to new users" settings from other settings · 5580903d
      Aaron Wells authored
      Bug 1267633: Currently the settings for forcing a page to be copied
      to new users, new groups, and new institution members, are only available
      if the page is set to be copyable and is viewable to logged-in users.
      But logically there's no reason to link those settings together.
      Change-Id: I68b4579d891a56e617a04947664d01d59e620bdf
  24. 15 Dec, 2013 1 commit
  25. 14 Oct, 2013 1 commit
  26. 21 Aug, 2013 1 commit
  27. 04 Feb, 2013 2 commits
  28. 03 Jan, 2013 1 commit
  29. 19 Dec, 2012 1 commit
  30. 14 Dec, 2012 1 commit
  31. 02 Nov, 2012 1 commit
    • Brian King's avatar
      Bug 1073136 another fix for forum sorting · 75f3ed93
      Brian King authored
      Fix ordering of forums when there are more than 10 forums
      ANSI SQL function CHAR_LENGTH (works on postgresql and mysql)
      is used to help sort the forums in the correct order.  Without this,
      if you have 11 forums, the 'order by' using the varchar weight value
      results in them being ordered 0, 1, 10, 2, 3, ....
      Apparently there is no my- and postgresql compatible syntax to cast
      strings to integers, so this patch orders first by string length, then
      by string value of the column storing the weight of the forum.
      Change-Id: I715f52d097189b9d3988339984220185cc1d6498
      Signed-off-by: default avatarBrian King <brian@liip.ch>
  32. 27 Sep, 2012 1 commit
  33. 10 Sep, 2012 1 commit
  34. 05 Sep, 2012 1 commit
  35. 04 Sep, 2012 1 commit
  36. 06 Aug, 2012 2 commits
  37. 01 Aug, 2012 1 commit