Skip to content

GitLab

Switch branch/tag
  1. 01 Sep, 2014 1 commit
  3. 07 Aug, 2014 1 commit
    • Nigel Cunningham's avatar
      (Bug1353802) Add query result caching to handle_event · 7441f64a
      Nigel Cunningham authored 
      

Improve the performance of handle_event by caching the results of
database queries. In testing adding 2000 users from a CSV file with
a typical number of fields (username, password, email, firstname,
lastname, studentid, address, town, city, country, homenumber,
mobilenumber), this change reduced the average import time over
three runs (with a fresh install each time) as follows:

                       Before      After     Saving
Total Wall Time        246s        114s       132s - 54%
handle_event           132s         21s       111s - 84%

(The change to handle_event seems to affect other functions'
execution times, perhaps due to other database caches still
being in memory that would otherwise be replaced).

Change-Id: Ibf28650df710dd807f95fca30a2dfc29ed92f5cd
Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
      7441f64a
  5. 24 Jul, 2014 1 commit
    • Robert Lyon's avatar
      User in multi institutions can lose progress bar (Bug #1347362) · 4a2e491e
      Robert Lyon authored 
      

If a user is in two (or more) institutions and the first institution has
profile progess set up for it and the other doesn't, the switching of
the select box makes the progress sideblock disappear.

This patch checks that if any institution the user belongs to has
profile progress then display the select box if they belong to two or
more institutions and show either the bar or a message mentioning this
intitution doesn't have progress.

To test:
- user with 1 institution that has progress
- user with 1 institution that has no progress
- user with 2 institution that both have progress
- user with 2 institution where one has progress
- user with 2 institution where none have progress

Change-Id: I4daca26b4b9cfef9faa73be34c34ad931d89465e
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      4a2e491e
  7. 21 Jul, 2014 1 commit
  9. 16 Jul, 2014 1 commit
  11. 01 Jul, 2014 2 commits
  13. 30 Jun, 2014 1 commit
  15. 24 Jun, 2014 1 commit
  17. 17 Jun, 2014 1 commit
  19. 16 Jun, 2014 1 commit
  21. 15 Jun, 2014 1 commit
  23. 13 Jun, 2014 1 commit
    • Aaron Wells's avatar
      Cleanup of the Plugin class · 6c89ad48
      Aaron Wells authored 
      

Bug 1328768

- Improving documentation

- Adding default implementations for the *_config_options methods because
that's a better means of documenting them than the function_exists() way

- Fixing the save_config_options() methods in the search plugins, which
should have been static.

Change-Id: Ib2bf1388843824e63cf6486176e97b8f874e1116
Signed-off-by: default avatarYuliya Bozhko <yuliya.bozhko@totaralms.com>
      6c89ad48
  25. 12 Jun, 2014 1 commit
    • Aaron Wells's avatar
      Refactor the Dwoo_Template_Mahara files · 97e96de0
      Aaron Wells authored 
      Bug 1231755

- Cleanup, documentation, and removing replicated code.

- Not checking for whether the file exists. We'll just make a list
of search paths and pass those through to Dwoo_Template_File, and
let it determine which path has the file.

- Eliminating the separate Dwoo_Template_Mahara classes for plugintypes,
and moving the custom logic for how plugintypes find their template files,
into the Plugin class itself.

Change-Id: I877a4221323333e8e8b6c6df54062a0f8bf2b817
      97e96de0
  27. 09 Jun, 2014 1 commit
  29. 05 Jun, 2014 1 commit
  31. 04 Jun, 2014 2 commits
  33. 27 May, 2014 1 commit
  35. 12 May, 2014 1 commit
  37. 09 May, 2014 1 commit
    • Yuliya Bozhko's avatar
      Some artefact refactoring (Bug #1298646) · 3ba72d71
      Yuliya Bozhko authored and Robert Lyon's avatar Robert Lyon committed 
      

Fixes in this patch:

- Moved artefact.php to artefacts directory to separate it from pages.
- Fixed reference to a wrong 'artefactonlyviewableinview' string.
- Removed add_to_render_path() and its calls which have no purpose at all.
- Removed 'artefact_parent_cache' table.
- Removed cron jobs related to 'artefact_parent_cache' from DB.
- Added 'path' column in 'artefact' table to easier calculate hierarchy.
- Added ArtefactTest.php for artefacts unit tests

Change-Id: Ia14cd85b94c32a950354446ee3565bd2964c625c
Signed-off-by: default avatarYuliya Bozhko <yuliya.bozhko@totaralms.com>
      3ba72d71
  39. 02 May, 2014 1 commit
    • Aaron Wells's avatar
      Removing unnecessary array_diff · 6ca2821a
      Aaron Wells authored 
      Bug 1314460: No need to remove $locked from $progressbaritems, because the
list of progressbaritems is limited by the $onlytheseplugins array, and that
has already had $locked removed from it.

Change-Id: Ie8418703d0333eaf2ef2ba8301ec235e4dcddd03
      6ca2821a
  41. 22 Apr, 2014 1 commit
  43. 06 Apr, 2014 1 commit
  45. 31 Mar, 2014 4 commits
  47. 30 Mar, 2014 1 commit
  49. 27 Mar, 2014 1 commit
  51. 25 Mar, 2014 1 commit
    • Aaron Wells's avatar
      Prevent new users from taking spammy actions · 7b08f438
      Aaron Wells authored 
      Bug 1252101

1. New users get 2 "new user points" on their user record

2. While they have these, they're on probation and can't post
links in public places, or make public pages.

3. "new user points" are decreased each time a non-probationary
user responds to a forum post by the user

4. Admins & Staff are automatically non-probationary

Change-Id: Ibccd2e330945f66b07aac062c4f51b67a0c0dba2
      7b08f438
  53. 07 Mar, 2014 1 commit
  55. 03 Mar, 2014 1 commit
  57. 09 Feb, 2014 1 commit
  59. 14 Jan, 2014 1 commit
  61. 08 Jan, 2014 2 commits
    • Jono Mingard's avatar
      Use global $CFG in get_configs_user_institutions() (Bug #1264429) · 3fdda559
      Jono Mingard authored 
      

The get_configs_user_institutions() method used the global $CFG variable
without declaring it, causing warnings when trying to set a property of it

Change-Id: Id02edcf735ffc3c8a779dc787715a6ba20626af1
Signed-off-by: default avatarJono Mingard <jonom@catalyst.net.nz>
      3fdda559
    • Aaron Wells's avatar
      Introducing the institution_config table · 5be3b920
      Aaron Wells authored 
      Bug 1264429: This patch creates the table, refactors the get_institution_config() method,
the Institution class, and the institution editing page, to use the new table.

Henceforth columns should only be added to the main "institution" table if they represent
a required setting (like name and displayname), or they need to be accessed frequently by
direct SQL queries.

Change-Id: I4564240d2c55ec2b6ec90868290a61cf4321460a
      5be3b920
  63. 07 Jan, 2014 1 commit
  65. 31 Dec, 2013 1 commit
  67. 21 Nov, 2013 1 commit