Remove acceptance of path parameter, not needed any more. Shorten the defining of the TITLE constant.

In particular, finally, the name of the user is linked to their profile page, which should surely help discovery of their profiles, given it's the main way that people see one another's content.

Removed the buggy old way of generating an artefact hierarchy path and replaced with something most likely slower but at least it's correct for now. Premature optimisation is the root of all evil, as they say. Flagged it with a comment for review later however.

Added a page title, and other misc. cleanup.

It does basically do what the old one did. I do want to poke it into having the feedback not need javascript though.

Namely: the string saying how many results there are, and the string that says there are no artefacts to choose from.

I was actually looking to fix a bug about it displaying the currently logged in user in search results, but there's a change on the forums branch that will allow this, and I don't want conflicts.

Now the items are layed out in a grid to the right of the searcher, which saves some vertical space and has more fluidity to the layout.

Also, the calendar elements have from/to text, which is a small violation of the language text freeze but makes the purpose of the calendar items for each element much clearer.

I'd like to add more text to this page as an explanation, though that would be a larger violation.

The fix basically works by adding a hidden submit button at the very beginning of the form. Its "name" is the same as for whatever current action is being performed. Thus, when enter is pressed, the same value is passed through.

In javascript mode, this form element's name attribute is poked every time a new element is configured to be correct for that. There is also some special event handling for the search tab of the artefact chooser, so it does not trigger a form submit - just a 'click' event on the correct button.

Changed all requires.
Also removed not used json/renderartefact.php

Use the key 'javascript' instead of 'js' everywhere, for consistency with the vast majority of stuff we already have doing things this way (render_self)

Renamed the 'view' parameter for view/view.php to be 'id'. 'view' will continue to work for a while.

view/blocks.php uses id, and id is used for other objects in the system, so it doesn't make much sense for this one to remain this way.

* In the non javascript version, make sure that request variables are not passed through, which can result in the newly chosen form artefact chooser starting on the wrong page
* In the javascript version, close the old form when opening a new one.

Also, added a 'loading' spinner/message to be displayed while the configuration form is being retrieved.

Call the new artefactchooser_element method to establish the data required to render the pagination. This means less data has to be passed to the script.

Also format the json_reply call a bit better.

Tell the template if the user viewing the view can also edit it, so a link can be displayed allowing them to do that.

The page was being first hit using the 'id' parameter, pieforms was building the form based on this. But the hidden element in the form was called 'viewid'. When the page was being hit again after form submission, the form was built again assuming 'viewid' held the view ID, which it did not anymore. Thus the form was built with and ID of 0, and the submit handler behaved appropriately - by creating a new view.

The small bug was that the 'save' button said 'new' when you were saving an existing view.

Now uses the centralised method of building the artefact chooser content, and uses extradata to make sure the correct page of results is being generated.

Added the artefactchooser pieform element, smarty templates and javascript file. Really rough first drafts.

Hook in the layout views css for the 'view view' page so it doesn't look like a pile of steaming wreckage

Show a message when redirecting back to the view edit page if no layouts are available for the view. Made sure this happens with five columns as well as one column

view/view.php reworked - all the blocktype and view class changes done in order to support non editable views