Liam Sharpe authored Mar 17, 2016 and Kristina Hoeppner committed Mar 18, 2016

behatnotneeded

Change-Id: Idcb92dda82a8f1eaafa20f258639b5e2d2b78113

There was a setting to stop the login link (top right) from showing if
there were sidebars on logged out homepage. This became a problem if
the login box was turned off (not counted as a sidebar block for some
reason) via $cfg->showloginsideblock = false;

But the top right login link should always show when logged out
whether a sidebar is in play or not.

behatnotneeded

Change-Id: I8d6c1916f165285afb1f0210a0ae9b364f3a7a4f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1558393

behatnotneeded: API change only

Change-Id: Iaa88093a12603db177dc475790b0b0bda8bda163

Bug 1558387

With this, we don't have to remember to bump HTML.DefinitionRev in
html_clean(), or clear the htmlpurifier directory in dataroot.

behatnotneeded: API change only

Change-Id: I15cd291fd8e5d7d5c357f1595a89f34f44236e7d

It got merged before I noticed the comment about needing a behat test

Change-Id: I1fd5bbdd88bc88cbde17992b9d7c9709f44b8e6f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

As there is already code to verify/submit group page comment
moderation I've added a bit of code to show the private pre-moderated
comments on group pages to group admins so they can moderate them.

Change-Id: Ia117ee00d26c7cf9050345488d65169caff16694
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded existing tests should be enough

Change-Id: I6316c6301c703353928c9e6210e02cdfc25151a8
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>
Signed-off-by: Aaron Wells <aaronw@catalyst.net.nz>

Since this blog post object wasn't committed after having its
description updated, it causes the destructor to try to save
the changes to the database, and that sometimes throws a fatal
error if PHP garbage-collects the global $db variable before it
calls this constructor.

behatnotneeded: Covered by existing "edit_journal.feature"

Change-Id: I5056ecce91b823b245cb5bd29f0676a35a6afd45

Robert Lyon authored Jan 27, 2016 and Aaron Wells committed Mar 16, 2016

As this is confusing debugging issues with view layout as the
view.numcolumns column is not actually used anymore for working
out the layout, but it's still being populated when a page is made.

behatnotneeded - existing tests will do

Change-Id: If90dff066201e7356601b08c9b7150cab8a77f45
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When displaying names for adding group members to groups

behatnotneeded

Change-Id: I0fb09eb1a17bd94c58533b8272db38e439897cbe
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

to make clearer that "Allow copying" and
"Copy for new users" are decoupled as per
Bug 1267633. Also fixes Bug 1557237.

behatnotneeded

Change-Id: Ib40a9d0a6ad10eb9c1481bfaa7ed7aa51ed3ce4c

The check to exclude current user from results was checking wrong and
forcing the group/institution pages to be ignored as well.

behatnotneeded

Change-Id: Id1566b0ad202e667b8c68294967bc6bc99220659
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

For the instition statistics users tab

Also fixing up the display of size in bytes, added round() to output
as it's not useful to show anything less than whole bytes

behatnotneeded

Change-Id: I13a842c910463660299b2b92d5319a03eacb2cab
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

As this is the preferred plugin for notifications now

Change-Id: I6ca49c863bb1cd9a8f3da891ebe2ab187c3d0a1e
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Robert Lyon authored Mar 03, 2016 and Aaron Wells committed Mar 14, 2016

Bug 1556692: When used together, these can cause problems when
the ID field from Moodle gets truncated to the default
get_new_username() length of "30", when being inserted into
usr.username in Mahara.

behatnotneeded: Can't test Mnet in Behat

Change-Id: Icdeb78b5298e7d63a0610987b0d8fad34e58d036

Robert Lyon authored Feb 15, 2016 and Kristina Hoeppner committed Mar 14, 2016

When 'Staff report access' is set to 'no'. This is due to the column
being built from both the 'select' and 'icon' part of the $cols array.

So need to pass in a mostly blank 'select' column info rather than
unset it.

Also fixed up the missing right side line on button when viewing page as
staff with 'Staff report access' set to 'yes'

behatnotneeded

Change-Id: I97d77f0dc136967efa16945114bcd990e49754d0
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: I3ce3f51bca51b91f5a6dc4883c8b7f52362163a6

Change-Id: I260db46eb83bb776f26790996b13fd0dcf555175
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

behatnotneeded

Change-Id: Ia7d8770536169703ef5bfc77e3e0dcb46e21dfcb

to match what users can see on the screen.

behatnotneeded

Change-Id: I375e9b1527a9ae90f79b0deccc67cccffc4997d4