1. 25 Sep, 2019 2 commits
    • Lisa Seeto's avatar
      Bug 1827811: Journal changes · f7431a3a
      Lisa Seeto authored
      Journal changes:
      Change the modal contents to not show post contents or attached files.
      Recent posts and Tagged posts (if not in full display) now expandable with post contents and comment links.
      Attached files on page block now links only to download and not to display further metadata.
      Cleaned up artefact.php links.
      remove metada that will show on entry on page from also showing in modal
      stop background page scrolling when the modal is opened and "Advanced licensing" is selected.
      add the blogpost_render_in_modal.tpl file
      get rid of scrolling for data-toggle collapse
      add block-header to journal, journal entry
      add titles as modal links for recent posts and tagged journal entries
      add comments and details icons for recent posts and tagged journal entries
      fix things from code review
      
      behatnotneeded
      
      Change-Id: Ic63ebf9fe42e7848559b5e009584fdff0a40770f
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      f7431a3a
    • Lisa Seeto's avatar
      Bug 1827811: Move "Add comment" and "Details" into modal with "Comments" · be7af61f
      Lisa Seeto authored
      create modal using configureblock id, update various templates to use the modal for blocks:
      Image
      Note
      File(s) to download
      Journal/blogs
      add JS to open/close modal, add comments, delete comments, reply to comments, paginate comments.
      add JS to handle url that redirects to view/view.php with modal open and populated.
      Further changes to each block will be completed in child patches.
      Add segment headings to the modal. Fix display of comments to cover width of modal.
      Show comment removed msg in modal/page appropriately.
      Fix behat test to close modal before continuing.
      do not show existing comments if comments not allowed on artefact.
      add validation to modal for comments/attachments
      disable image as link when editing for image block
      trigger focus on modal for accessibility
      close modal on escape keydown event
      fix merge conflict in view/view.php
      fix merge conflict with master
      make configureblock modal play nicely when comment block is on the page
      update display of error messages to always show at top of modal so user doesn't have to scroll
      add accesibility to close modal on escape key down
      handle dock show/hide events for paginated pages in modal during validation
      create block-comments-details-header template file
      create details button and custom scss file with js to show and hide header
      update comment links to save add comment and details when commentcount == 0
      add active-block class to colour the block-header when active
      toggle the details-btn active css
      add _block-comments-details-header.scss to patch
      change class invisble to class d-none
      add block-comments-details-header.tpl to blocktypecontainerviewing.tpl
      code review changes
      add .no-modal class to links on group home page, dashboard and profile page.
      add block header to appear above the title
      change assessbtn from anchor tag to button to prevent scrolling.
      make all clickable links clickable on page load (ignore assess mode)
      fix js issues surrounding assessbtn move and show/hide blocks
      change cursor on dashboard, my profile page, group homepage to default when over disabled modal links
      update assessbtn to details btn
      create tooltip for hover over file download block titles
      fix containerElm console log error by not reattaching tinymce unneccessarily.
      fix null named attributes issues on e.target when span (icons) instead of anchor is clicked.
      
      Change-Id: I2e5218c040f8a9e252f785165ce9c566ecc2f56e
      Signed-off-by: default avatarLisa Seeto <lisaseeto@catalyst.net.nz>
      be7af61f
  2. 09 Jul, 2019 1 commit
    • Rebecca Blundell's avatar
      Bug 1811904: Fontawesome - yet more name changes · e84165b0
      Rebecca Blundell authored
      icon-calendar       -> icon-regular icon-calendar-alt
      icon-check-square-o -> icon-regular icon-check-square
      icon-square-o       -> icon-regular icon-square
      icon-circle-o         -> icon-regular icon-circle
      icon-legal          -> icon-gavel
      icon-level-up       -> icon-level-up-alt
      icon-long-arrow-down-> icon-long-arrow-alt-down
      long-arrow-left     -> icon-long-arrow-alt-left
      long-arrow-right    -> icon-long-arrow-alt-right
      long-arrow-up       -> icon-long-arrow-alt-up
      
      icon-remove         -> icon-times || icon-user-times
      (times is the 'x'used elsewhere, user-times is the 'x' next to a profile person.
      Remove has been removed so I have deleted it from the styleguide)
      
      icon-level-up       -> icon-level-up-alt
      icon-heart-o        -> icon-regular icon-heart
      icon-arrows         -> icon-arrows-alt
      
      icon-sign-in        ->icon-sign-in-alt
      
      Change-Id: Ia2cd81ea24119a7d0fec3000af1eaf2571a2a62b
      e84165b0
  3. 25 Jun, 2019 1 commit
    • Rebecca Blundell's avatar
      Bug 1811904: Fontawesome - Name changes · 7b952964
      Rebecca Blundell authored
      new default for fontawesome is 'solid',
      where we are using a different class (regular or brand),
      we need to add these.
      
      also confirming that where the icon name has changed, we've
      picked that up.
      
      Where there's a choice of icon, I've kept it as close to what we
      currently have as possible.
      All free icons can be seen here:
      https://fontawesome.com/icons?d=gallery&m=free
      
      Name changes:
      icon-trash-alt      -> icon-trash
      icon-pencil         -> icon-pencil-alt
      icon-unlock-alt     -> icon-unlock
      icon-files-o        -> icon-regular icon-copy
      icon-pencil-square  -> icon-regular icon-edit
      icon-file-text      -> icon-file-alt || icon-regular icon-file-alt
      icon-image          -> icon-regular icon-image
      
      behatnotneeded
      
      Change-Id: I34646a6857f6cf54dc39572f5a66c07da4f4c0e2
      7b952964
  4. 14 Jun, 2019 1 commit
  5. 30 Apr, 2019 1 commit
  6. 26 Feb, 2019 7 commits
  7. 24 Oct, 2018 1 commit
  8. 07 Aug, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1741987: Update jquery - Events · 3d1abcc2
      Cecilia Vela Gurovic authored
      Event
         Breaking change: .load(), .unload(), and .error() removed
         Breaking change: .on("ready", fn) removed
         Breaking change: event.pageX and event.pageY normalization removed
         Breaking change: jQuery.event.props and jQuery.event.fixHooks removed
         Breaking change: Delegated events with bad selectors throw immediately
         Deprecated: .bind() and .delegate()
           no calls to .bind() for events in core.
           Only calls to bind() refer to the js bind of arguments to functions.
           no calls to unbind() for event in core.
           Only calls to unbind refer to the unbind method defined in
           formChangeManager not related to the jQuery method.
      
          Warnings fix
          JQMIGRATE: jQuery.fn.click() event shorthand is deprecated
          - also applies to the other event shorthands, including:
           blur, focus, focusin, focusout, resize, scroll, dblclick, mousedown,
           mouseup, mousemove, mouseover, mouseout, mouseenter, mouseleave,
           change, select, submit, keydown, keypress, keyup, and contextmenu.
      
          JQMIGRATE: jQuery.fn.hover() is deprecated
          JQMIGRATE: jQuery(window).on('load'...) called after load event occurred
      	(for FileBrowser we can see this error when editing a block in a page)
      
      behatnotneeded
      
      Change-Id: I1a50050f882b864ad63d273de160e0b441a77705
      3d1abcc2
  9. 28 Mar, 2018 1 commit
  10. 19 Mar, 2018 1 commit
    • Robert Lyon's avatar
      Bug 1755919: Adding related tags page and adjusting tag filter · 0ad5b688
      Robert Lyon authored
      This patch contains the following:
      - created a relatedtags.php page + json file + template to handle the
      viewing of related tags for a user, the differences for this to
      tags.php page are:
      -- it can be viewed publically
      -- it requires a tag and viewid
      
      - Adjusted the filters for blog/blogpost, plan/task so they appear
      under their own filters as well as 'text' filter
      
      - adjusted the dwoo function list_tags so that we can pass an array of
      viewids/tags and/or just a view id
      
      -adjusted the portfolio_search_* functions so they would work for both
      my tags and related tags pages
      
      - fixed a filter js problem for tags.php where choosing the filter was
      not updating the displayed filter string
      
      behatnotneeded
      
      Change-Id: Ie3a2c3cb56e94ced0e021265bce88e35a9cfba5d
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      0ad5b688
  11. 28 Feb, 2018 1 commit
  12. 06 Dec, 2017 1 commit
  13. 12 Oct, 2017 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1721623: added plugin's css to be controlled by sass · 80c4b140
      Cecilia Vela Gurovic authored
      For both raw and raw_old
      
      Not moving files that are only used for styling
      html exported static page:
      
      theme/raw/plugintype/export/html/style/style.css
      theme/raw/plugintype/export/html/style/print.css
      
      theme/raw/plugintype/artefact/internal/export/html/style/style.css
      	used only in exported static page:
      	<path-to-static-page>/files/internal/index.html
      
      theme/raw/plugintype/artefact/resume/export/html/style/style.css
      	used only in exported static page:
      	<path-to-static-page>/files/resume/index.html
      
      the same for raw_old
      
      Change-Id: Ief02aaee3bd86a30c6cae529953500a3a36ca8c9
      behatnotneeded: styles
      80c4b140
  14. 11 Oct, 2017 1 commit
  15. 04 Oct, 2017 1 commit
  16. 28 Mar, 2017 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1666685: hide buttons from users with no access to group journal · cf735e83
      Cecilia Vela Gurovic authored
      When a member/tutor dont have access to edit or create
      in the group, the buttons to edit, publish, create entry,
      create journal, delete, are hidden.
      
      Also, when a group edit/create access permission is
      changed, we update the role permissions for each
      blog and blogpost artefact in the group.
      
      behatnotneeded
      
      Change-Id: Ic06fbc7112f14a6038cdb0bb3beb8f93aed6f633
      cf735e83
  17. 09 Mar, 2017 1 commit
  18. 20 Jan, 2017 1 commit
    • Pat Kira's avatar
      Bug 1606735 - Changed heading markup where possible for accessibility · 60c7eca5
      Pat Kira authored
      This patch excludes:
      - Admin section
      - H4 in the pieform since it was added to improve accessibility
      - User generated page/content
      
      Note: There are still number of pages with heading being skipped heading
      especially H2. Most of the pages have H1 and H3, H1 for page heading and
      h3 for sidebar panel heading. We can look into marking up sideber panels
      as sections with header etc.
      
      behatnotneeded: markup and styles changes only
      
      Change-Id: Ic592f5be63aa2e7fbd7e31928db7c230e425f104
      60c7eca5
  19. 12 Jan, 2017 1 commit
  20. 10 Jan, 2017 1 commit
  21. 14 Dec, 2016 1 commit
  22. 14 Nov, 2016 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1565199: Filter Recent Journals block Add entry + errors · 88b94532
      Cecilia Vela Gurovic authored
      In the block Recent journal entries, the drop-down menu
      only shows the Journals which the user has permission to
      add a new entry.
      
      Also corrected error showing up and broken Journal search
      in the Edit block side screen.
      
      Also fixed the poor alignment of the artefactchoooser search form's
      search button
      
      Also fixes Bug 1636850 with change in lib/view.php
      
      behatnotneeded
      
      Change-Id: I44c0d6d25eda7cb37d4a8aab66a6d1b93ca60b69
      88b94532
  23. 14 Sep, 2016 1 commit
  24. 08 Jun, 2016 1 commit
  25. 23 Mar, 2016 1 commit
  26. 07 Mar, 2016 1 commit
    • Aaron Wells's avatar
      "Tagged journal entries" block shouldn't grant access to whole journal · ada12dba
      Aaron Wells authored
      Bug 1521818. Making the "Tagged journal entries" block act more like
      a collection of "Journal entry" blocks. So, it doesn't add the parent
      blog to view_artefacts, only the specific blog entries that are
      displayed in the block.
      
      Also removing the title of the parent blog (and the link to it) from
      the list of blog entries, like the "Journal entry" block, which
      doesn't display the title of the containing journal.
      
      Note the viewer may still have access to the whole blog, if the blog
      is also shared on the same page via a "blog" or "recent journal entries"
      block.
      
      Change-Id: I33fc7e58b964c03bc8003f1de81a4bf58b6079b7
      ada12dba
  27. 11 Jan, 2016 1 commit
    • Aaron Wells's avatar
      Remove blocktype thumb.png files (Bug 1532642) · 5577c929
      Aaron Wells authored
      Since we're no longer using theme in any of the core themes.
      
      Note that the code to look for a thumb.png file is still in place,
      for backwards-compatibility with older 3rd-party blocktypes.
      
      If you're a third-party theme developer who wants to use PNG files
      for the block picker instead of FontAwesome, you'll need to provide
      your own thumb.png files for each of the core blocktypes, under
      your theme's /theme/THEMENAME/plugintype... directories.
      
      behatnotneeded: Covered by existing tests
      
      Change-Id: I6f0578c8f55c620b7b3df42d8959a6d1ea5ad016
      5577c929
  28. 16 Dec, 2015 2 commits
  29. 26 Nov, 2015 2 commits
  30. 15 Nov, 2015 1 commit
    • Robert Lyon's avatar
      Bug 1514374: Fixing pagination in a number of places · 0cbdb0e1
      Robert Lyon authored
      1) Group member search results pagination
      2) Blog index page (when user has multiple blogs turned on)
      3) Collection index page didn't have json pagination when it should
      for consistency
      4) My views block on index page
      
      Was looking for certain ID to replace results table but could not find
      it
      
      behatnotneeded
      
      Change-Id: I7f55717fd4375d5c6bd1a4977a834a32dd172338
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      0cbdb0e1
  31. 22 Oct, 2015 1 commit