1. 30 Jul, 2020 1 commit
  2. 30 Jun, 2020 1 commit
  3. 22 Jun, 2020 2 commits
  4. 15 Jun, 2020 1 commit
  5. 02 Jun, 2020 1 commit
  6. 25 May, 2020 2 commits
  7. 18 May, 2020 2 commits
  8. 11 May, 2020 2 commits
  9. 04 May, 2020 1 commit
  10. 25 Apr, 2020 1 commit
  11. 24 Apr, 2020 1 commit
    • Rebecca Blundell's avatar
      Bug 1839411: Update Mahara to work with PHP7.3/7.4 · 4263848b
      Rebecca Blundell authored and Cecilia Vela Gurovic's avatar Cecilia Vela Gurovic committed
      Fixed strpos error picked up by 7.3
      I haven't found any other 7.3 issues and none have been caught by behat
      
      For 7.4:
      -Fixed implode param order (glue, parts)
       Note that Mink has a reversed implode not fixed upstream:
       external/vendor/behat/mink/src/Selector/Xpath/Escaper.php:50
       I have added a function to copy the correct code over in the interim
       I also pushed a change to an HTMLPurifier file as it is not fixed upstream
      -Changed a variable read by fread to allow for false return type
      -Calling a non-array as an array now causes an error, meaning we need to
       confirm an array value before attempting to use a variable. An obvious
       case is in multi-record db calls the return value is either an array of
       results or false. E.g.
          $array = db_call();//returns false as no results
          //do sth with result
          $var = $array[0]//error, trying to access type false as array
          //instead we need to check the value before accessing:
          $var = !empty($array[0]) ? $array[0] : false //or some equivalent
          check of the db_call's return
       Because of this change, I have attempted to check all the multi-db
       calls for possible false results and include a check for that if there
       wasn't already one.
      -In conjunction with the previous work, I noticed that trying to use
       foreach on a non-iterable result causes an error and that array
       functions (i.e. array_keys()) called on a non-array also cause an
       error. Where I found them I added checks as well.
      -A change in PHP7.2 was that items counted with count() must implement
       Countable. (i.e, int/bool is not OK). I fixed the ones I found.
      -I used the regex \{\$?\d?[^\s]\} to search for array access using {}
       instead of [] and changed those. (Note: the regex pulls in a lot more)
       CSStidy has a lot of these that aren't fixed, but those are covered by
       the CSStidy upgrade (Bug 1840099)
      
      Change-Id: I64a8feb821433ecd99463762a9999449c50ee32e
      4263848b
  12. 01 Apr, 2020 1 commit
  13. 31 Mar, 2020 2 commits
  14. 30 Mar, 2020 1 commit
  15. 26 Mar, 2020 1 commit
    • Rebecca Blundell's avatar
      Bug 1843357: Remove deprecated jquery selectors · 15ed3e6e
      Rebecca Blundell authored and Cecilia Vela Gurovic's avatar Cecilia Vela Gurovic committed
      These are:
      :first -> .first() or css first-child
      :last -> .last() or css last-child
      :eq -> .eq() or css nth-of-type(n)
      :even -> css nth-child(odd) (odd because we're
        going from 0->1 based indexing)
      And these which were not found in Mahara:
      :odd
      :gt
      :lt
      
      Change-Id: I512db61de687f9ea3d7a31b1514f4aa962bcb1b0
      15ed3e6e
  16. 20 Mar, 2020 1 commit
  17. 14 Mar, 2020 2 commits
  18. 09 Mar, 2020 1 commit
  19. 08 Mar, 2020 1 commit
  20. 05 Mar, 2020 1 commit
  21. 28 Feb, 2020 1 commit
  22. 30 Jan, 2020 1 commit
  23. 22 Jan, 2020 2 commits
  24. 07 Jan, 2020 1 commit
  25. 18 Dec, 2019 1 commit
  26. 11 Dec, 2019 1 commit
  27. 29 Nov, 2019 1 commit
  28. 08 Nov, 2019 1 commit
  29. 24 Oct, 2019 1 commit
  30. 22 Oct, 2019 1 commit
  31. 13 Oct, 2019 1 commit
  32. 07 Oct, 2019 2 commits
    • Robert Lyon's avatar
      Bug 1841988: Making sure pieform is generated before smarty_core() call · 22e4a2dd
      Robert Lyon authored
      
      
      There are a few places where this was not being done in correct order
      
      Also fixed up the add admins / staff pages so that submitting nothing
      gives an error
      
      behatnotneeded
      
      Change-Id: Ib60a3a4ffce0e73b38c42badc57cfc6fe6db372c
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      22e4a2dd
    • Doris Tam's avatar
      Bug 920246: Adding category filter to admin/groups/groups.php · c541934b
      Doris Tam authored and Robert Lyon's avatar Robert Lyon committed
      - Like the group/index.php page with the filter, this page also
        has a problem with the button when the width of screen is too small
      - Added a parameter to an existing helper function for groupcategory
        (build_group_list_html
      - Helper function group_get_extended_data(..) to htdocs/lib/group.php
      - Fix previous bug failure due to button class change for submit
      - Styling for table changed to to "break-word" to stop truncating words
      - overflow of buttons controlled + responsive results heading+footer
      - button moved to first level of form to stop button cutting button on
        small screen
      behatnotneeded
      
      Change-Id: I646135f6963f944b6d253d800882a77cac995e1a
      c541934b