1. 30 Jul, 2020 1 commit
  2. 25 May, 2020 1 commit
  3. 24 Apr, 2020 1 commit
    • Rebecca Blundell's avatar
      Bug 1839411: Update Mahara to work with PHP7.3/7.4 · 4263848b
      Rebecca Blundell authored and Cecilia Vela Gurovic's avatar Cecilia Vela Gurovic committed
      Fixed strpos error picked up by 7.3
      I haven't found any other 7.3 issues and none have been caught by behat
      
      For 7.4:
      -Fixed implode param order (glue, parts)
       Note that Mink has a reversed implode not fixed upstream:
       external/vendor/behat/mink/src/Selector/Xpath/Escaper.php:50
       I have added a function to copy the correct code over in the interim
       I also pushed a change to an HTMLPurifier file as it is not fixed upstream
      -Changed a variable read by fread to allow for false return type
      -Calling a non-array as an array now causes an error, meaning we need to
       confirm an array value before attempting to use a variable. An obvious
       case is in multi-record db calls the return value is either an array of
       results or false. E.g.
          $array = db_call();//returns false as no results
          //do sth with result
          $var = $array[0]//error, trying to access type false as array
          //instead we need to check the value before accessing:
          $var = !empty($array[0]) ? $array[0] : false //or some equivalent
          check of the db_call's return
       Because of this change, I have attempted to check all the multi-db
       calls for possible false results and include a check for that if there
       wasn't already one.
      -In conjunction with the previous work, I noticed that trying to use
       foreach on a non-iterable result causes an error and that array
       functions (i.e. array_keys()) called on a non-array also cause an
       error. Where I found them I added checks as well.
      -A change in PHP7.2 was that items counted with count() must implement
       Countable. (i.e, int/bool is not OK). I fixed the ones I found.
      -I used the regex \{\$?\d?[^\s]\} to search for array access using {}
       instead of [] and changed those. (Note: the regex pulls in a lot more)
       CSStidy has a lot of these that aren't fixed, but those are covered by
       the CSStidy upgrade (Bug 1840099)
      
      Change-Id: I64a8feb821433ecd99463762a9999449c50ee32e
      4263848b
  4. 31 Mar, 2020 1 commit
  5. 26 Mar, 2020 1 commit
    • Rebecca Blundell's avatar
      Bug 1843357: Remove deprecated jquery selectors · 15ed3e6e
      Rebecca Blundell authored and Cecilia Vela Gurovic's avatar Cecilia Vela Gurovic committed
      These are:
      :first -> .first() or css first-child
      :last -> .last() or css last-child
      :eq -> .eq() or css nth-of-type(n)
      :even -> css nth-child(odd) (odd because we're
        going from 0->1 based indexing)
      And these which were not found in Mahara:
      :odd
      :gt
      :lt
      
      Change-Id: I512db61de687f9ea3d7a31b1514f4aa962bcb1b0
      15ed3e6e
  6. 28 Feb, 2020 1 commit
  7. 29 Sep, 2019 1 commit
  8. 12 Aug, 2019 1 commit
  9. 04 Aug, 2019 1 commit
  10. 09 Jul, 2019 1 commit
    • Rebecca Blundell's avatar
      Bug 1811904: Fontawesome - final name changes · c3479dc6
      Rebecca Blundell authored and Robert Lyon's avatar Robert Lyon committed
      icon-clipboard      -> icon-clipboard-check
      icon-eye            -> icon-regular icon-eye
      icon-eye-slash      -> icon-regular icon-eye-slash
      icon-file-archive-o -> icon-regular
      icon-comments-o     -> icon-comments
      icon-external-link  -> icon-external-link-alt
      icon-tachometer     -> icon-tachometer-alt
      icon-rotate-right   -> icon-redo
      icon-file-archive-o -> icon-file-archive
      icon-comments-o     -> icon-comments
      icon-send           -> icon-paper-plane
      icon-lightbulb-o    -> icon-regular icon-lightbulb
      icon-code-fork      -> icon-code-branch  - changed versioning to
      'history' icon
      icon-file-o         -> icon-regular icon-file
      
      also changed some icons to new ones
      used text-align, width and margin-right to centre list items.
      
      behatnotneeded
      
      Change-Id: I4d27e450a281dc49716d97de309a3c99b89a0bc1
      c3479dc6
  11. 25 Jun, 2019 1 commit
    • Rebecca Blundell's avatar
      Bug 1811904: Fontawesome - Name changes · 7b952964
      Rebecca Blundell authored and Robert Lyon's avatar Robert Lyon committed
      new default for fontawesome is 'solid',
      where we are using a different class (regular or brand),
      we need to add these.
      
      also confirming that where the icon name has changed, we've
      picked that up.
      
      Where there's a choice of icon, I've kept it as close to what we
      currently have as possible.
      All free icons can be seen here:
      https://fontawesome.com/icons?d=gallery&m=free
      
      Name changes:
      icon-trash-alt      -> icon-trash
      icon-pencil         -> icon-pencil-alt
      icon-unlock-alt     -> icon-unlock
      icon-files-o        -> icon-regular icon-copy
      icon-pencil-square  -> icon-regular icon-edit
      icon-file-text      -> icon-file-alt || icon-regular icon-file-alt
      icon-image          -> icon-regular icon-image
      
      behatnotneeded
      
      Change-Id: I34646a6857f6cf54dc39572f5a66c07da4f4c0e2
      7b952964
  12. 26 Feb, 2019 3 commits
  13. 07 Aug, 2018 1 commit
    • Cecilia Vela Gurovic's avatar
      Bug 1741987: Update jquery - Events · 3d1abcc2
      Cecilia Vela Gurovic authored and Robert Lyon's avatar Robert Lyon committed
      Event
         Breaking change: .load(), .unload(), and .error() removed
         Breaking change: .on("ready", fn) removed
         Breaking change: event.pageX and event.pageY normalization removed
         Breaking change: jQuery.event.props and jQuery.event.fixHooks removed
         Breaking change: Delegated events with bad selectors throw immediately
         Deprecated: .bind() and .delegate()
           no calls to .bind() for events in core.
           Only calls to bind() refer to the js bind of arguments to functions.
           no calls to unbind() for event in core.
           Only calls to unbind refer to the unbind method defined in
           formChangeManager not related to the jQuery method.
      
          Warnings fix
          JQMIGRATE: jQuery.fn.click() event shorthand is deprecated
          - also applies to the other event shorthands, including:
           blur, focus, focusin, focusout, resize, scroll, dblclick, mousedown,
           mouseup, mousemove, mouseover, mouseout, mouseenter, mouseleave,
           change, select, submit, keydown, keypres...
      3d1abcc2
  14. 09 Feb, 2018 1 commit
  15. 12 Dec, 2016 1 commit
  16. 18 Oct, 2016 1 commit
  17. 26 Sep, 2016 1 commit
    • Aaron Wells's avatar
      Bug 1533377: Browserid end-of-life migration script · cfef0ff9
      Aaron Wells authored
      This patch removes all authentication functionality
      from the browserid auth plugin. It adds a script,
      accessible through the plugin's configuration page,
      to migrate user accounts from browserid to
      internal auth.
      
      Also includes changes to allow users to be searched
      by authtype, and to prevent non-useable plugins
      from being enabled on the plugin config page.
      
      Change-Id: I4e8bd9fc4d2fb2ccaa1845fda533c9373ec251bd
      behatnotneeded: Can't test with behat
      cfef0ff9
  18. 01 Sep, 2016 2 commits
  19. 15 Jul, 2016 1 commit
  20. 21 Mar, 2016 1 commit
    • Robert Lyon's avatar
      Bug 1539262: Removing unnecessary $smarty PAGEHEADING lines · e82c0fcb
      Robert Lyon authored
      
      
      As they are set to TITLE we can just assign TITLE to PAGEHEADING in
      the smarty function call.
      
      We can later override the PAGEHRADING with
      $smarty->assign('PAGEHEADING', string); if we need to.
      
      Have also updated a few files where TITLE was not defined.
      
      behatnotneeded - everything should work as before
      
      Change-Id: I3ea592cd37344e68c6e90a3c64947cf99db59471
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      e82c0fcb
  21. 29 Feb, 2016 1 commit
  22. 24 Feb, 2016 1 commit
  23. 04 Jan, 2016 1 commit
  24. 16 Dec, 2015 2 commits
  25. 09 Dec, 2015 1 commit
  26. 06 Oct, 2015 1 commit
  27. 20 Sep, 2015 1 commit
  28. 08 Sep, 2015 1 commit
  29. 21 Aug, 2015 1 commit
  30. 30 Jul, 2015 1 commit
  31. 23 Jul, 2015 1 commit
    • Robert Lyon's avatar
      Bug 1467368: Allowing the main menu structure to be cached · ec41d0e0
      Robert Lyon authored and Aaron Wells's avatar Aaron Wells committed
      
      
      This will allow the rendering of the main nav to use less resources.
      
      The cached menus are saved for each institution into the
      institution_config table for these types of menus:
      
      adminnav     - site administration navigation
      instadminnav - institution admin navigation
      staffnav     - site staff admin navigation
      inststaffnav - institution staff admin navigation
      standardnav  - navigation seen in normal section of site
      
      To clear cache menus call clear_menu_cache($institution)
      
      Change-Id: I3b58090830b6d28f10f24e23abeef775c6863aa5
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      ec41d0e0
  32. 18 Jul, 2015 1 commit
  33. 15 Jun, 2015 4 commits