GitLab

fixes bug #1915 where if a user has more than one email set it thinks there are none set at all

A bit of a hack - see the comment in the diff.

 * Give authentication plugins titles and descriptions, which are used by the authlist pieform element so people see an easier name
 * Add a new API method to the PluginAuth class, is_usable(). This can be used by auth plugins to check that required extensions are available. The authlist element will tell the user what they need to do to enable a plugin.

changing ldap to work when only email is set

Some whitespace cleanups. Add a log_info line for when authentication using a new authentication instance fails, to assist people debugging what might be wrong.

Some whitespace cleanups. Add a log_info line for when authentication using a new authentication instance fails, to assist people debugging what might be wrong.

Remove some bunk code around setting the 'institution' cookie, which was only used for auto populating the institution dropdown in the login box, which we don't have anymore.

Don't session_destroy before creating a new liveuser, I don't have any evidence that it does anything useful now.

If an authentication plugin thinks that a user should be able to log in, and furthermore thinks that it is able/allowed to automatically create user accounts, then it is now able to do just that. The authentication API now has a new method - can_auto_create_users() - to define whether each authentication instance feels it can/should be able to do this.

If the instance thinks it can, it needs to export some information through the get_user_info method in order to populate the user account. Although this may change shortly to be optional, with the users instead being forced to enter any information that is required that they haven't otherwise filled out.

Ensure that the user's e-mail address is set correctly if it needs to be set when changing password.

Fix a fatal error when registering. password_validate expected a User object, which register.php cannot provide, so loosened the type hint on the function.

Signed-off-by: Andrew McMillan

Ensure that when a user is deleted, suspended or has their account expired, they really are unable to log in.

Not sure for how long this has been broken, but it seems that deleted users could browse around the site just fine. They don't show up in search results but you can still view their profile page...

Move account expiry from institution to site options; add theme, membership period to institution settings

Better handling when the user is logged out and they try a json request. Ajax login is lying around somewhere, must integrate that some time.

Improved the error reporting of the XMLRPC auth plugin, by catching more specific exceptions and logging unknown ones. Added a TODO about a bad catch elsewhere

Fixed bug #1120 - broken language string when attempting to register with invalid password. Thanks to Aaron.

Now, table names (and other identifiers that could be confused with SQL kewords), should be put into SQL like this:

SELECT * FROM {artefact}

The braces are matched and expanded by DML now to include the prefix and be properly quoted, which means that tables like 'view' and 'group' don't need renaming (and nor should they, there's little reason why we should rename tables to get around such constraints).

This has removed a whole bunch of $prefix = ... and get_config('dbprefix') stuff, which makes things a little simpler yet again.

Removed debug code that would cause users to have to change their password unnecessarily when upgrading. Some code formatting fixes, and removed a catch-all-exceptions block that only hides why errors have occured