GitLab

This reverts commit 63896cc8.

It's no longer necessary to update these URLs, because
commit 0de9fa76 makes the old-style URLs redirect to the
new-style URLs. And since this rewrite will be a lengthy
operation on large sites, and could potentially cause
problems with URLs for other domain names that happen to
contain "view/artefact.php", we should just remove this
upgrade section.

Change-Id: Ic981f739d6ac5e76efe8116531fc365947ebf286

Needed to use a temp table as update and select are from same table

Change-Id: Idddf6048b2f6cf6cff2fadad87b8703a56a7a8d5
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1236102: In commit 5b7b2927, a bad rebase resulted in
additional changes to lib/db/upgrade.php being committed, beyond
those actually needed for the patch.

Change-Id: I3d22ea01f17ded7a4304b2fa8eb74cc48e317002

This is on the page edit screen

Change-Id: I1e96837c2292cbf9fb6c44bcb291bf722b079329
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Aaron Wells authored Nov 07, 2014 and Robert Lyon committed Feb 02, 2015

Bug 1236102. Also sorting the "text" and "image" blocks while I'm at it.

Change-Id: I09c3a1bec1ec9a7ddf0b3f1cfca735759dd2bbbe

there are places where people have added html with view/artefact.php
links - needs to be artefact/artefact.php now

Change-Id: I28a54bbbe5ffb21a6bc0ca94e65cdb1114c9f08d
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1401324

Make sure 263 calls of the functions are valid

Change-Id: I791c14969b20ea1c7dff03cc092db9ff79f37a3a
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Change-Id: I49cbd9196efca256bb0959e59dfc56aa2ba4e4e2

Yuliya Bozhko authored Nov 13, 2014 and Aaron Wells committed Dec 12, 2014

Change-Id: I32faf161d9ef7c9cd020134a08998ce48acc7060
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

Bug 1400524: On a large site, the database queries to retrieve
all records from the artefact table can take too long to execute
and cause the PHP script to time out.

This optimization attempts to fix that by filling in the paths
with an iterative series of UPDATE queries instead.

Change-Id: I46c13cc97bac8a6d2bc626e3b2dc8e4cdeecd2bb

Bug 1400524: On a large site, the database queries to retrieve
all records from the artefact table can take too long to execute
and cause the PHP script to time out.

This optimization attempts to fix that by separately handling
the simpler case of parentless artefacts, and by removing
a redundant "select * from artefact"

Change-Id: Iddcfea3161fbfe804ec808119fe771757e7cdd5e

A mistake was made where a user was allowed to add more than one
"group pages" block to the group homepage. This wasn't a problem until
we added pagination to the "group pages" block.

This patch attempts to clean up that error and merge any existing
multiple block instances into one "group pages" block instance.

Change-Id: I38acada835a4c245c97f0008543519a9dd2072a3
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

1. Data generator
2. Config manager
3. Form fixtures
4. Some sample test features

Add shell script for running Behat

Moving core feature files to 'test' folder outside the docroot

Fix Mysql bugs

Change-Id: I00f3558c178541ae7f81ce9fb1ce6226e7a9654e
Signed-off-by: Aaron Barnes <aaronb@catalyst.net.nz>
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Aaron Wells authored Nov 07, 2014 and Robert Lyon committed Nov 12, 2014

Bug 1390339: Before, we had hard-coded the "image" and "text" blocks into
the top of the block picker. With this change, a block developer can
just give their blocktype the category "shortcut" and it will show up there.

Change-Id: Ibaafc481745dd290442aa125b637394084705b00

Bug 1384481

Change-Id: I14a61c08229de51f8e0bb25aa12c42826f2f1639

Aaron Wells authored Oct 23, 2014 and Robert Lyon committed Nov 05, 2014

Bug 1384481

Change-Id: Ia34c51ccae2859e3860896a5fa9fda5a4cbff1dc

Due to the line 1868 in lib/db/upgrade.php
commit 1e4f1c55



All group homepages were locked including the one owned by root user.
That was fine before as one couldn't edit the root user's template
but now you can so we need to let this view be unlocked.

Only an issue if upgrading from version before 1.5.0

Change-Id: I02c28c0300ad9d640171c5870fa8630b0793e473
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Allowing for them to be deleted correctly

Change-Id: Ie2c9b38e5f77eb3b4dcc2d3fe93e68134f964d9f
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1380200 - make sure main two do not have 'none' option
Bug 1380829 - make sure the previous default email method is respected

On upgrade from 1.9 the default core notifications 'System message'
and 'Message from other users' can be set to 'none' - which is not
allowed.

This patch will fix that problem by making sure the default core
notifications are set to email and that any users are also updated to
beusing the newly set default method.

Also deals with setting the default email method correctly - the prev
change to notifications didn't set the default email method with the
correct currently being used method.

Change-Id: I98dcc8374876e20cb5c2952121b69dab99c7cf19
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1246702

Change-Id: I5fcc98779c0a496b64273ebbc7f8f7312d91bfcc

Bug 605749

Change-Id: Id577778e84860d5b4917fbc032eaa7b8486a5908

Gregor Anzelj authored Sep 07, 2014 and Robert Lyon committed Sep 24, 2014

- Added ability to self import and import via admin the socialprofile
fields, whether the leap2a file is made with this patch or with older
mahara

- Note: the msn messaging profile will not import into the new system
as it is obsolete

Change-Id: I858acc6c71af61c689e6760991dc00f983b913ac
Signed-off-by: Gregor Anzelj <gregor.anzelj@gmail.com>

This patch contains:
- The export queue system where pages/collections on release from
submission are added to the export queue table ready to be archived.
- The export queue admin page showing what is in the queue to be
exported. The cron runs every 6 minutes. Queue items failed to export
are also shown here.
- The archive list admin page, where one can download the generated
leap2a files for the archived submissions.

In this patch you should be able to add things to the export queue by
either releasing a sumbission on a group that has 'archive
submissions' option ticked. This will add the archive to that archived
submission page, or you can also run a leap2a export from portfolio
export which will add the export queue and send you an email once the
export is done.

Things to note:
- The is a server busy function that stops the export queue from
running but I'm not too sure if the threshold is too low/high
- The export queue tries to export the first 100 items each run but if
resources are fine in handling that easily then the number could be
higher but I'm not sure of what will be a good number.
- Currently there is alsoe infrastructure like table columns for dealing
with releasing submissions from external systems (eg moodle) but that
functuionality is yet to be built.
- The checking of server busy in MS windows untested - may need to
just let MS ignore server busy check as there doesn't seem to be
standard way to check this.

Change-Id: If4c1d272e9c5d46fbf16b2ff73ceb2687c06ffd4
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

missing a closing } on an if statement.

Change-Id: Icc0194e6c5753e006551afe50334a89937572f0a
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This patch adds support for anonymising pages.

It creates a site option in the General Settings section named 'Allow
anonymous pages' that must be checked for any page to be anonymised.

If the site option is enabled, a new 'Anonymise' setting in the
'Edit title and description' tab of pages is enabled, allowing the owner
to request that this page be anonymised.

When both settings are enabled and a user views a page, two things may
happen to the author's information.

First, if the user is not logged in or does not have admin, staff or
owner privileges for the page, the author's name is replaced by the
anonymous text (defaulting to "(Author's name hidden)") in both the
body of the page and the metadata author field.

If the user does have admin, staff or owner privileges for the page,
the author's name is anonymised as above except that the text displayed
is made into a link. When this link is clicked, the anonymous author
text is replaced by the normal author information for the page.

Anonymous pages displayed in the 'Latest pages' block and shared with
a group are also anonymised by this patch.

Change-Id: I2e2c92f641329a1a305cf58a5c5d47bf95436a8b
Signed-off-by: Nigel Cunningham <nigelc@catalyst-au.net>

When upgrading, should only check if the cron job 'auth_clean_expired_password_requests' already exists
in the table - without all the other fields that need to be updated.
Otherwise, it will check on all the fields (i.e. minute, hour, etc).  If the admin updated them,
the check won't match and a duplicate error results.

Change-Id: I2d30ac97e9a82aaf0d538a834396fdc2d2757480
Signed-off-by: Ghada El-Zoghbi <ghada@catalyst-au.net>

So as to seperate the 'text' block from the 'note' block

I figured just changing the viewable text from 'text box' to 'note' will
be fine as we have in another occasion changed blog to journal but
still have the info in the db recorded as blog.

I've also replaced the hardcoded 'textbox/note' block option to with
the new 'text' block option at top of chooser list.

And forced the site upgrade to install this new 'text' block.

Change-Id: Ib40815cc359fc0d4eb715009e506f5fd3e36ee57
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Son Nguyen authored Jun 10, 2014 and Robert Lyon committed Jul 31, 2014

Another patch for bug 1314440 makes it so that when you delete an
institution, this data gets deleted. This patch cleans up the data
for institutions that were deleted before that patch was merged.

Change-Id: I167001f444a3fd204b12610ca10274d6218d9f96
Signed-off-by: Son Nguyen <son.nguyen@catalyst.net.nz>

Problem with ensure_record_exists checking nextrun column will break
things when adding new cron line to cron table.

This is due the the nextrun not being null after it has run.

Change-Id: I1f674cbc842a3e061224bf996cc0267b09018f55
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1338410

Change-Id: I5a15029b9c7fdaccd76072f632ef59234c22e835

In this patch:
- Changed the Group Edit 'General' section and added the 'Feedback
notifications' options.
- Changed the Group Edit 'General' section and altered the 'Shared
page' option from tickbox to select options.
- Changed the CommentFeedback to be able to notify multiple users in a
group
- Changed the CommentFeedback to be able to send message in the
institution lang if needed.
- Adjusted group_get_editroles_options() to allow it to return a non
associative array
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Change-Id: Ia2e995c51aa08610945788e55c809b3c650dcd17

Make add_key() and drop_key() consistent with other DDL functions by checking if the key does or does not exist respectively (Bug #1330277)

Change-Id: Ifd1ff659dd27e312108641bb49a599ffa9d4c9ff
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

Nathan Lewis authored Jun 24, 2014 and Aaron Wells committed Jun 24, 2014

Content from the following commits was reverted:

Patch 3327: 7a7673c0
"Add activity stream block (Bug #1316324)"

Patch 3374: c538c745
"Add likes to activity streams (Bug #1321480)"

Patch 3432: 121e9027
"Add new parameters to the get_activity_body function (Bug #1328729)"

Patch 3434: 2e47dfb1


"Improvements to activity stream body helper (Bug #1328760)"

Change-Id: Id03c156a7c8c016c8dc76c998a73310ea57fe0a5
Signed-off-by: Nathan Lewis <nathan.lewis@totaralms.com>

Robert Lyon authored Apr 23, 2014 and Aaron Wells committed Jun 20, 2014

Seen as we already have an expiry column in the db we might as well
use it.

Change-Id: I4de92289edff40e26c74ff8b9e4a77cf9bd8ccf2
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Bug 1328768: A new generic plugintype for any plugins that don't fit other types

Change-Id: I706241d73947805a5d3f8d623c4bc8dc0d94429b

Bug 1239461

Change-Id: Ib574072c06aec2c12bb113f2c2429bd733aebcc6

Change-Id: I689fb61b4f75c56dca0e1e400e74c14580afb133
Signed-off-by: Nathan Lewis <nathan.lewis@totaralms.com>

Bug 1298646: No point in adding columns to the interaction_forum_post table
just to immediately drop them again.

Also, there were some lingering "accesstype IS NULL" checks in the elasticsearch
access queries, which should have been removed along with the "accesstype != objectionable"
that they were previously parenthetical with.

And, the artefact_access table doesn't need to accept "objectionable" as 
an accesstype enum value anymore.

Change-Id: I961f15e98eb8aab95e4e5b16af223eb61588f671
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>

Change-Id: I49c15aed9e36da0ff4ea4e1fa4d110c112a25215
Signed-off-by: Nathan Lewis <nathan.lewis@totaralms.com>

- Created 'objectionable' table
- Migrated existing objectionable records to a new table
- Added is_objectionable() method to View class
- Fixed can_view_view() and elasticsearch to use new table
- Fixed artefact.tpl style to match view page when displaying "Not objectionable" form
- Make forum reports use new 'objectionable' table

Change-Id: Ib3759e86c4003216ad57f3cf68911b13e50e9c67
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>