Commit 102e956e authored by Doris Tam's avatar Doris Tam 🌷 Committed by Robert Lyon
Browse files

Bug: 1902679 Add confirmation delete step ext app 

Added a browser dialog window for when users try deleting an external app.
This prevents users from accidentally deleting the wrong item.

Change-Id: I713e9e8f822596eea6c740705a1a68683432665a
(cherry picked from commit 95c90f50)
parent 4045714e

htdocs/auth/webservice/lang/en.utf8/auth.webservice.php

+1 −0
Original line number Diff line number Diff line
@@ -279,6 +279,7 @@ $string['oauth_access'] = 'This application will have access to your users\' det 
$string['oauth_instructions'] = 'If you wish to grant access to this application, then click "Authorise application access". If you do not want to grant access, press "Cancel".';

$string['setauthinstancefailed'] = 'Setting the "Web services" authentication for institution "%s" failed. Please try adding it via Administration -> Institutions -> Settings page.';

$string['needtosetowner'] = 'Need to set an owner for this service';

$string['confirmdeleteexternalapp'] = 'Are you sure you want to delete this external app?';



// running webservices messages

$string['accesstofunctionnotallowed'] = 'Access to the function %s() is not allowed. Please check if a service containing the function is enabled. In the service settings: If the service is restricted, check that the user is listed. Still in the service settings check for IP restriction or if the service requires a capability.';

htdocs/webservice/admin/oauthv1sregister.php

+1 −0
Original line number Diff line number Diff line
@@ -507,6 +507,7 @@ function webservice_server_list_form($sopts, $iopts) { 
                                'usebuttontag' => true,

                                'class' => 'btn-secondary btn-sm',

                                'value' => '<span class="icon icon-trash-alt icon-lg text-danger" role="presentation" aria-hidden="true"></span><span class="sr-only">'.get_string('deletespecific', 'mahara', $consumer->application_title).'</span>',

                                'confirm' => get_string('confirmdeleteexternalapp', 'auth.webservice'),

                                'elementtitle' => get_string('deletespecific', 'mahara', $consumer->application_title),

                            ),

                        ),