Commit 5a7040ae authored by Liam Sharpe's avatar Liam Sharpe Committed by Robert Lyon
Browse files

Added role=presentation to all icons - Bug #1484781 

behatnotneeded

Change-Id: I536f7d4ab8bd96d653e0ae3bba635437f0d2c17c
parent 264e72e0

htdocs/admin/extensions/iframesites.php

+1 −1
Original line number Diff line number Diff line
@@ -102,7 +102,7 @@ foreach ($iframesources as $url => $name) { 
                    'type'         => 'button',

                    'class'        => 'btn-default btn-sm',

                    'usebuttontag' => true,

                    'value'          => '<span class="icon icon-trash icon-lg text-danger"></span><span class="sr-only">'. get_string('delete') . '</span>',

                    'value'          => '<span class="icon icon-trash icon-lg text-danger" role="presentation"></span><span class="sr-only">'. get_string('delete') . '</span>',



                    'confirm'      => get_string('confirmdeletemenuitem', 'admin'),

                ),

htdocs/admin/extensions/plugins.php

+3 −3
Original line number Diff line number Diff line
@@ -149,12 +149,12 @@ $failurestring = json_encode(get_string('upgradefailure', 'admin')); 
$javascript = <<<JAVASCRIPT



function installplugin(name) {

    $(name + '.message').innerHTML = '<span class="{$loadingicon}" title=' + {$loadingstring} + '"></span>';

    $(name + '.message').innerHTML = '<span class="{$loadingicon}" title=' + {$loadingstring} + '" role="presentation"></span>';



    sendjsonrequest('../upgrade.json.php', { 'name': name }, 'GET', function (data) {

        if (!data.error) {

            var message = {$successstring} + data.newversion;

            $(name + '.message').innerHTML = '<span class="{$successicon}" title=":)"></span>' + message;

            $(name + '.message').innerHTML = '<span class="{$successicon}" title=":)" role="presentation"></span>' + message;

            $(name + '.install').innerHTML = '';

            jQuery($(name)).removeClass('list-group-item-danger').addClass('list-group-item-success');

            // move the whole thing into the list of installed plugins
@@ -174,7 +174,7 @@ function installplugin(name) { 
            else {

                message = {$failurestring};

            }

            $(name).innerHTML = '<span class="{$failureicon}" title=":("></span>' + message;

            $(name).innerHTML = '<span class="{$failureicon}" title=":(" role="presentation"></span>' + message;

        }

    },

    function () {

htdocs/admin/groups/groupcategories.php

+2 −2
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ function formatrow (item) { 
        'type':'button',

        'title':{$getstring['edit']},

        'alt':{$getstring['editspecific']}.replace('%s', item.name)},

            SPAN({'class':'icon icon-cog icon-lg'}),

            SPAN({'class':'icon icon-cog icon-lg', 'role':'presentation'}),

            SPAN({'class':'sr-only'}, {$getstring['editspecific']}.replace('%s', item.name))

        );
@@ -104,7 +104,7 @@ function formatrow (item) { 
        'type':'button',

        'title':{$getstring['delete']},

        'alt':{$getstring['deletespecific']}.replace('%s', item.name)},

            SPAN({'class':'icon icon-trash text-danger icon-lg'}),

            SPAN({'class':'icon icon-trash text-danger icon-lg','role':'presentation'}),

            SPAN({'class':'sr-only'}, {$getstring['deletespecific']}.replace('%s', item.name))

        );

htdocs/admin/site/menu.php

+3 −3
Original line number Diff line number Diff line
@@ -73,9 +73,9 @@ function formatrow (item) { 
    // item has id, type, name, link, linkedto

    var type = eval(item.type);

    var linkedto = A({'href':item.linkedto},item.linktext);

    var edit = BUTTON({'type':'button','class':'button btn btn-default btn-sm'}, SPAN({'class':'icon icon-lg icon-pencil left'}), {$getstring['edit']});

    var edit = BUTTON({'type':'button','class':'button btn btn-default btn-sm'}, SPAN({'class':'icon icon-lg icon-pencil left', 'role':'presentation'}), {$getstring['edit']});

    connect(edit, 'onclick', function () { edititem(item); });

    var del = BUTTON({'type':'button','class':'button btn btn-default btn-sm'}, SPAN({'class':'icon icon-lg icon-times text-danger left'}), {$getstring['delete']});

    var del = BUTTON({'type':'button','class':'button btn btn-default btn-sm'}, SPAN({'class':'icon icon-lg icon-times text-danger left', 'role':'presentation'}), {$getstring['delete']});

    connect(del, 'onclick', function () { delitem(item.id); });

    var buttonGroup = SPAN({'class':'btn-group'}, edit, del);

    var cells = map(
@@ -107,7 +107,7 @@ function editform(item) { 


    // Either a save, a cancel button, or both.

    var savecancel = [];

    var save = BUTTON({'type':'button','class':'button btn btn-default btn-sm'}, SPAN({'class':'icon icon-plus-circle icon-lg'}));

    var save = BUTTON({'type':'button','class':'button btn btn-default btn-sm'}, SPAN({'class':'icon icon-plus-circle icon-lg', 'role':'presentation'}));

    connect(save, 'onclick', function () { saveitem(item.id); });



    // The link field will be a text box or a select in the case of an admin file.

htdocs/admin/site/networking.php

+1 −1
Original line number Diff line number Diff line
@@ -105,7 +105,7 @@ $networkingform = pieform( 
                        'name' => 'submit', // must be called submit so we can access it's value

                        'type'  => 'button',

                        'usebuttontag' => true,

                        'content' => '<span class="icon icon-refresh icon-lg left text-danger"></span> '. get_string('deletekey', 'admin'),

                        'content' => '<span class="icon icon-refresh icon-lg left text-danger" role="presentation"></span> '. get_string('deletekey', 'admin'),

                        'value' => 'deletekey'

                    )

                )