Commit 9a2d21fa authored by Robert Lyon's avatar Robert Lyon
Browse files

Bug 1482448: Check element has title attribute 



Before trying to pass it to get_help_icon()

Fieldset elements don't need titles but can have help icons

behatnotneeded

Change-Id: Ib37797514f9173cab9b172fdd4f0d88034b9373a
Signed-off-by: default avatarRobert Lyon <robertl@catalyst.net.nz>
parent b7824081

htdocs/lib/web.php

+1 −1
Original line number Diff line number Diff line
@@ -2181,7 +2181,7 @@ function pieform_get_help(Pieform $form, $element) { 
    $plugintype = isset($element['helpplugintype']) ? $element['helpplugintype'] : $form->get_property('plugintype');

    $pluginname = isset($element['helppluginname']) ? $element['helppluginname'] : $form->get_property('pluginname');

    $formname = isset($element['helpformname']) ? $element['helpformname'] : $form->get_name();

    return get_help_icon($plugintype, $pluginname, $formname, $element['name'], '', '', $element['title']);

    return get_help_icon($plugintype, $pluginname, $formname, $element['name'], '', '', (isset($element['title']) ? $element['title'] : null));

}



/**