Commit aed26def authored by Evonne Cheung's avatar Evonne Cheung
Browse files

Bug #1994908 Chevron on plan tasks in 'Edit' mode sits incorrectly 

Also fixed chevron in the block header in edit mode to sit higher.

behatnotneeded

Change-Id: I263947bd888e35740de64157784330329511bfd9
parent 45bf8344

htdocs/theme/raw/plugintype/artefact/plans/templates/view/plantasks.tpl

+1 −1
Original line number Diff line number Diff line
@@ -6,7 +6,7 @@ 
            <button class="btn btn-secondary btn-sm" data-url="{$WWWROOT}artefact/plans/task/delete.php?id={$task->id}{if $view}&view={$view}{/if}" title="{str tag='deletethistask' section='artefact.plans' arg1=$task->title}"><span class="icon icon-trash-alt text-danger"></span></button>

        </div>

        {/if}

        <span class="{if $task->completed == -1}overdue-task{else}complete-task{/if}">

        <span class="task-item-content{if $task->completed == -1} overdue-task{else} complete-task{/if}">

            {if $task->completed == -1}

                <span class="icon icon-times text-danger icon-lg left task{$task->id}{if $editing || $canedit} plan-task-icon{/if}" role="presentation" aria-hidden="true" data-task="{$task->id}"></span>

                <span class="visually-hidden">{str tag=overdue section=artefact.plans}</span>

htdocs/theme/raw/sass/components/_indicator.scss

+4 −0
Original line number Diff line number Diff line
@@ -63,6 +63,10 @@ 
    .card-secondary h2.card-header & {

      margin-top: 0.625rem; // 10px;

    }

    // but not on edit screen

    .card-secondary h2.card-header .btn-group-top & {

      margin-top: 0;

    }

}



// just valigning the attachment indicator

htdocs/theme/raw/sass/features/_plan-task.scss

+7 −0
Original line number Diff line number Diff line
@@ -39,4 +39,11 @@ 
            margin: $spacing-base 0 0 0;

        }

    }



    // when on edit page, chevron needs to move a little to the left to make space for buttons

    .btn-group-top ~ .task-item-content {

      .plan-task-heading .collapse-indicator {

        margin-right: 1rem;

      }

    }

}