Commit ddb5d389 authored by Robert Lyon's avatar Robert Lyon Committed by Cecilia Vela Gurovic

Bug 1857255: IE11 was having issues displaying the verify modal

but only in some cases was it showing as partially invisible

to get it to render correctly I just moved the modal in the dom
and that seems to sorted out the IE11 render engine handling of it

Change-Id: Ibe2f43ea4346aabb39f41cc90931528accb2c223
Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
parent c1c51e8e
......@@ -117,6 +117,7 @@ class PluginBlocktypeSignoff extends MaharaCoreBlocktype {
public static function instance_config_save($values, $instance) {
$viewid = $instance->get_view()->get('id');
ensure_record_exists('view_signoff_verify', (object) array('view' => $viewid), (object) array('view' => $viewid), 'id', true);
$values['title'] = '';
return $values;
}
......
......@@ -1632,5 +1632,10 @@ function xmldb_core_upgrade($oldversion=0) {
}
}
if ($oldversion < 2020012800) {
log_debug('Remove the heading from signoff blocks');
execute_sql("UPDATE {block_instance} SET title = '' WHERE blocktype = 'signoff'");
}
return $status;
}
......@@ -16,7 +16,7 @@ $config = new stdClass();
// See https://wiki.mahara.org/wiki/Developer_Area/Version_Numbering_Policy
// For upgrades on stable branches, increment the version by one. On master, use the date.
$config->version = 2020011700;
$config->version = 2020012800;
$config->series = '20.04';
$config->release = '20.04dev';
$config->minupgradefrom = 2017031605;
......
......@@ -119,7 +119,8 @@ $(function() {
$('#verify').on('click', function(event) {
event.preventDefault();
event.stopPropagation();
$j("#verify-confirm-form").modal('show');
$('body').prepend($('#verify-confirm-form')); // Move form in DOM so it display ok in IE11
$("#verify-confirm-form").modal('show');
});
$('#verify-yes-button').on('click', function(event) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment