1. 14 Nov, 2017 1 commit
  2. 08 Oct, 2017 1 commit
  3. 26 Jan, 2017 1 commit
  4. 25 Jan, 2016 1 commit
  5. 09 Dec, 2015 1 commit
  6. 08 Jul, 2015 1 commit
  7. 02 Jun, 2015 1 commit
  8. 25 Mar, 2015 1 commit
  9. 03 Mar, 2015 1 commit
    • Nigel Cunningham's avatar
      (Bug1352028) Add a JSON progress bar for bulk operations. · 55a8deb8
      Nigel Cunningham authored
      This patch adds a JSON progress meter (I'll call it that to avoid confusion
      with progress bars) to the bulk uploading of users, groups and group
      memberships and the bulk export and import of users (LEAP), so the user can see
      the progress of the operation and not just the submit button changed to
      'Processing..' and whatever indication their browser gives while waiting for
      content.
      
      The bulk export and import are minor rewrites, replacing the old iframe based
      progress bar and the associated multiple pages and additional template file in
      the case of the bulk export, and the recursive redirect-to-self of the bulk
      import.
      
      To accomplish the display of the progress bar during the operation, we make the
      PHP session be closed (read only) except when changes need to be made. This is
      for the most part a straightforward change in session.php as it's the only
      direct accessor. In other places, we replace direct accessing of the session
      variable ($_SESSION) with use of the session class ($SESSION) so that it can
      reopen the session, make the change and close the session again.
      
      There is one more aspect to all of this: with previous behaviour, multiple
      requests for the same session would queue, taking the session lock in turn.
      After this patch is applied, they can proceed in parallel, allowing greater
      throughput. There is no additional locking requirement because the issues are
      the same as those already dealt with in allowing multiple PHP threads to
      process requests from different sessions at the same time.
      
      I have sought to make the progress meter nice and generic, so it can be used in
      the other bulk imports and exports too.
      
      Paradoxically, these changes don't just make the import seem to be faster, it
      actually is.. at least in the case of users and groups.
      
      Times for importing 1000 users, groups and memberships, averaged over 3 runs
      each (Wall time, not CPU time - but the relationship is the same).
      
                      Without Progress     With Progress
      Users                166s               155s
      Groups                85s                78s
      Memberships           20s                19s
      
      Change-Id: Iec15c57db32c77994edb80c71d65591de51a95e4
      Signed-off-by: default avatarNigel Cunningham <nigelc@catalyst-au.net>
      55a8deb8
  10. 20 Nov, 2014 1 commit
    • Robert Lyon's avatar
      Session is not invalidating after password change (Bug #1363873) · f103c650
      Robert Lyon authored
      Scenario/testing:
      
      - Create an account, say User A and logout as admin.
      - In one browser login (this will be the hacker user)
      - In another browser reset pass via forgotten pass link
      
      What should happen:
      User in browser two should be able to reset pass then navigate about
      as when normally logged in. User in browser one should be forced to
      login again as their user sessionid is not valid anymore.
      
      Before patch:
      malicious user still has access until $USER->logout_time time expires
      
      After patch:
      malicious user foreced to re-login straight away on next page load
      
      Change-Id: I42ad907e5ffa7c128742a159116cf20dc6cd9b8a
      Signed-off-by: Robert Lyon's avatarRobert Lyon <robertl@catalyst.net.nz>
      f103c650
  11. 02 Nov, 2014 1 commit
  12. 19 Jun, 2014 1 commit
  13. 25 Feb, 2014 1 commit
  14. 14 Oct, 2013 1 commit
  15. 09 Apr, 2012 1 commit
  16. 21 Feb, 2012 1 commit
  17. 13 May, 2011 1 commit
  18. 21 Dec, 2010 1 commit
  19. 14 Dec, 2010 1 commit
  20. 20 Jul, 2010 1 commit
  21. 08 Apr, 2010 1 commit
  22. 20 Nov, 2009 1 commit
  23. 15 Sep, 2009 1 commit
  24. 08 Mar, 2009 1 commit
  25. 11 Sep, 2008 1 commit
    • Nigel McNie's avatar
      The 'forgot password' feature can now tell you your username. · 844d71ef
      Nigel McNie authored
      You can now enter your username and be sent a password reminder too.
      
      Several users of MyPortfolio have reported issues when they thought they knew their username but they didn't. Hopefully the email now telling you your username will help this.
      
      Several language strings had to be changed. This is a bit suck, going on 1.0_STABLE.
      844d71ef
  26. 16 Feb, 2008 2 commits
  27. 30 Jan, 2008 1 commit
  28. 23 Dec, 2007 1 commit
  29. 04 Dec, 2007 1 commit
  30. 25 Nov, 2007 1 commit
  31. 17 Sep, 2007 1 commit
  32. 14 Sep, 2007 1 commit
  33. 13 Sep, 2007 1 commit
  34. 27 Jul, 2007 1 commit
  35. 10 May, 2007 1 commit
  36. 13 Apr, 2007 1 commit
    • Penny Leach's avatar
      complete rework of page level contextual help. Introduces three new · e974c6ce
      Penny Leach authored
      constants - SECTION_PLUGINTYPE, SECTION_PLUGINNAME, SECTION_PAGE -
      which are used to build up the page help thing instead of trying to parse
      the url.  I have only added these constants to pages that had page help,
      it would be a good idea to add checks for them to file_content_check
      and definitely add them in when they're missing
      e974c6ce
  37. 12 Apr, 2007 1 commit
  38. 24 Jan, 2007 1 commit
  39. 17 Jan, 2007 1 commit