GitLab

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Useful if the Makefile is missing certain new steps
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

... currently this is just Catalyst IT. But in theory if there were
another software company with multiple developers working on this
project we could easily add them as well.

We can still run unit tests and the minaccept, to gain information
about the patch, before we decide to exit because the uploader forgot
to write a Behat test for it.

For security reasons, it's unwise to allow running of arbitrary code
uploaded my members of the general public. This test should limit
automated test running, to code uploaded by users who have been
manually added to the "Mahara Testers" or "Mahara Reviewers" groups.
(And/or code that has a +2 code review)

The check is against the code *uploader*, not the Gerrit change *owner*,
so if a patch is rebased by a trusted user, it will trigger automatic
code execution.

Since they're both PHP now, there's no need to invoke
gerrit_query.php in a separate process.

When backporting patches the different branch info comes thru and the
first item in array is not necessarily the one we want to check so we
need to check the object with right branch information.
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

And alerting user to the problem
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

This reverts commit af3ec01f.

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

When the first patch being checked is already merged.

We need to reject out before checking gerrit as we don't have a commit
id to check against
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Now automated testing will fail for all patches that don't make a change
to at least one Behat test file. Unless the patch commit message includes
the phrase "behatnotneeded".

This happens if the job is added to jenkins queue and then patchset is
updated/rebased before the job is run.

Patch will stop running tests on obsolete patchset
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

But not for any parents it has.
This is useful if we retrigger the test from jenkins
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

unknown revision or path not in the working tree.
Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

Signed-off-by: Robert Lyon <robertl@catalyst.net.nz>

To Do - work out why the call to the php file is failing
Signed-off-by: root <root@mahara-jenkins>